From: "Andrew F. Davis" <afd@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] ARM: OMAP2+: Introduce check for OP-TEE in omap_secure_init()
Date: Mon, 30 Dec 2019 13:40:05 -0500 [thread overview]
Message-ID: <d8062353-47bb-b31f-a263-76ba1674b891@ti.com> (raw)
In-Reply-To: <20191230173659.GN35479@atomide.com>
On 12/30/19 12:36 PM, Tony Lindgren wrote:
> * Andrew F. Davis <afd@ti.com> [191218 01:01]:
>> On 12/17/19 7:53 PM, Tony Lindgren wrote:
>>> * Andrew F. Davis <afd@ti.com> [191217 23:48]:
>>>> --- a/arch/arm/mach-omap2/omap-secure.c
>>>> +++ b/arch/arm/mach-omap2/omap-secure.c
>>>> @@ -20,6 +21,18 @@
>>>>
>>>> static phys_addr_t omap_secure_memblock_base;
>>>>
>>>> +bool optee_available;
>>>
>>> The above can be static bool optee_available?
>>>
>>>> --- a/arch/arm/mach-omap2/omap-secure.h
>>>> +++ b/arch/arm/mach-omap2/omap-secure.h
>>>> @@ -10,6 +10,8 @@
>>>> #ifndef OMAP_ARCH_OMAP_SECURE_H
>>>> #define OMAP_ARCH_OMAP_SECURE_H
>>>>
>>>> +#include <linux/types.h>
>>>> +
>>>> /* Monitor error code */
>>>> #define API_HAL_RET_VALUE_NS2S_CONVERSION_ERROR 0xFFFFFFFE
>>>> #define API_HAL_RET_VALUE_SERVICE_UNKNWON 0xFFFFFFFF
>>>> @@ -72,6 +74,7 @@ extern u32 rx51_secure_dispatcher(u32 idx, u32 process, u32 flag, u32 nargs,
>>>> extern u32 rx51_secure_update_aux_cr(u32 set_bits, u32 clear_bits);
>>>> extern u32 rx51_secure_rng_call(u32 ptr, u32 count, u32 flag);
>>>>
>>>> +extern bool optee_available;
>>>> void omap_secure_init(void);
>>>
>>> And then this change should not be needed, right?
>>>
>>
>>
>> I have a staged change I'm about to post that makes use of this flag
>> from outside of omap-secure.c, otherwise I would have left it internal
>> to that file.
>>
>> I could also have moved the flag in the patch that uses it, but it
>> seemed like an unnecessary change given I know it will be needed here soon.
>
> OK best to post all them together. Or initially just set it static
> as otherwise people reading the patches will wonder about it with
> no user. And all the automated test systems will start sending out
> patches :)
>
Okay, I'll post everything together, will add the extra patch for AM43xx
HS suspend/resume that uses this to the end of this series.
Thanks,
Andrew
> Regards,
>
> Tony
>
next prev parent reply other threads:[~2019-12-30 18:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 23:47 [PATCH v2 0/3] Use ARM SMC Calling Convention when OP-TEE is available Andrew F. Davis
2019-12-17 23:47 ` [PATCH v2 1/3] ARM: OMAP2+: Add omap_secure_init callback hook for secure initialization Andrew F. Davis
2019-12-17 23:47 ` [PATCH v2 2/3] ARM: OMAP2+: Introduce check for OP-TEE in omap_secure_init() Andrew F. Davis
2019-12-18 0:53 ` Tony Lindgren
2019-12-18 1:00 ` Andrew F. Davis
2019-12-30 17:36 ` Tony Lindgren
2019-12-30 18:40 ` Andrew F. Davis [this message]
2019-12-17 23:47 ` [PATCH v2 3/3] ARM: OMAP2+: Use ARM SMC Calling Convention when OP-TEE is available Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8062353-47bb-b31f-a263-76ba1674b891@ti.com \
--to=afd@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).