From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D0B3C432C0 for ; Mon, 25 Nov 2019 16:23:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C3CB20740 for ; Mon, 25 Nov 2019 16:23:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728849AbfKYQXV (ORCPT ); Mon, 25 Nov 2019 11:23:21 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:60400 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728683AbfKYQXV (ORCPT ); Mon, 25 Nov 2019 11:23:21 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 0D4C4260849 Subject: Re: [PATCH 2/4] i2c: i2c-cros-ec-tunnel: Fix ACPI identifier To: Raul E Rangel , Wolfram Sang Cc: Akshu.Agrawal@amd.com, linux-kernel@vger.kernel.org, Guenter Roeck , Benson Leung , Neil Armstrong , Dmitry Torokhov , linux-i2c@vger.kernel.org, dlaurie@chromium.org References: <20191121211053.48861-1-rrangel@chromium.org> <20191121140830.2.I68b9a92ed4def031c3f247d3b49996a2512d762d@changeid> From: Enric Balletbo i Serra Message-ID: Date: Mon, 25 Nov 2019 17:23:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191121140830.2.I68b9a92ed4def031c3f247d3b49996a2512d762d@changeid> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Raul, On 21/11/19 22:10, Raul E Rangel wrote: > The initial patch was using the incorrect identifier. > > Signed-off-by: Raul E Rangel > --- > There are currently no boards using the identifier so it's fine to > change it. > Right, I don't see GOOG001A being used but also I don't see GOOG0012. Anyway, for the CrOS EC side, the change looks good to me. I think this will go through the I2C tree? Acked-by: Enric Balletbo i Serra Thanks, Enric > drivers/i2c/busses/i2c-cros-ec-tunnel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c > index ac2412755f0a..5d91e33eb600 100644 > --- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c > +++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c > @@ -299,7 +299,7 @@ static const struct of_device_id cros_ec_i2c_of_match[] = { > MODULE_DEVICE_TABLE(of, cros_ec_i2c_of_match); > > static const struct acpi_device_id cros_ec_i2c_tunnel_acpi_id[] = { > - { "GOOG001A", 0 }, > + { "GOOG0012", 0 }, > { } > }; > MODULE_DEVICE_TABLE(acpi, cros_ec_i2c_tunnel_acpi_id); >