From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Johan Hovold <johan+linaro@kernel.org>, Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 11/11] phy: qcom-qmp-pcie: drop bogus register update
Date: Fri, 30 Sep 2022 13:57:46 +0300 [thread overview]
Message-ID: <d82b0c09-194d-9357-a887-f0c8f81fb6ab@linaro.org> (raw)
In-Reply-To: <20220929092916.23068-12-johan+linaro@kernel.org>
On 29/09/2022 12:29, Johan Hovold wrote:
> Since commit 0d58280cf1e6 ("phy: Update PHY power control sequence") the
> PHY is powered on before configuring the registers and only the MSM8996
> PCIe PHY, which includes the POWER_DOWN_CONTROL register in its PCS
> initialisation table, may possibly require a second update afterwards.
>
> To make things worse, the POWER_DOWN_CONTROL register lies at a
> different offset on more recent SoCs so that the second update, which
> still used a hard-coded offset, would write to an unrelated register
> (e.g. a revision-id register on SC8280XP).
>
> As the MSM8996 PCIe PHY is now handled by a separate driver, simply drop
> the bogus register update.
>
> Fixes: e4d8b05ad5f9 ("phy: qcom-qmp: Use proper PWRDOWN offset for sm8150 USB") added support
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> #RB3
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-09-30 11:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 9:29 [PATCH v2 00/11] phy: qcom-qmp: more fixes and cleanups Johan Hovold
2022-09-29 9:29 ` [PATCH v2 01/11] phy: qcom-qmp: fix obsolete lane comments Johan Hovold
2022-09-29 9:29 ` [PATCH v2 02/11] phy: qcom-qmp-combo: drop unused UFS reset Johan Hovold
2022-09-29 9:29 ` [PATCH v2 03/11] phy: qcom-qmp-pcie: drop unused common-block registers Johan Hovold
2022-09-29 9:29 ` [PATCH v2 04/11] phy: qcom-qmp-pcie: clean up power-down handling Johan Hovold
2022-09-29 10:09 ` Dmitry Baryshkov
2022-09-29 9:29 ` [PATCH v2 05/11] phy: qcom-qmp-pcie: move power-down update Johan Hovold
2022-09-29 19:05 ` Dmitry Baryshkov
2022-09-29 9:29 ` [PATCH v2 06/11] phy: qcom-qmp-pcie-msm8996: clean up power-down handling Johan Hovold
2022-09-29 10:07 ` Dmitry Baryshkov
2022-09-29 9:29 ` [PATCH v2 07/11] phy: qcom-qmp-combo: " Johan Hovold
2022-09-29 10:08 ` Dmitry Baryshkov
2022-09-29 9:29 ` [PATCH v2 08/11] phy: qcom-qmp-ufs: " Johan Hovold
2022-09-29 10:18 ` Dmitry Baryshkov
2022-09-29 9:29 ` [PATCH v2 09/11] phy: qcom-qmp-usb: " Johan Hovold
2022-09-29 10:09 ` Dmitry Baryshkov
2022-09-29 9:29 ` [PATCH v2 10/11] phy: qcom-qmp-pcie: clean up clock lists Johan Hovold
2022-09-29 10:08 ` Dmitry Baryshkov
2022-09-29 9:29 ` [PATCH v2 11/11] phy: qcom-qmp-pcie: drop bogus register update Johan Hovold
2022-09-29 10:18 ` Dmitry Baryshkov
2022-09-29 12:39 ` Johan Hovold
2022-09-30 10:57 ` Dmitry Baryshkov [this message]
2022-09-30 11:25 ` Johan Hovold
2022-09-29 9:47 ` [PATCH v2 00/11] phy: qcom-qmp: more fixes and cleanups Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d82b0c09-194d-9357-a887-f0c8f81fb6ab@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=kishon@ti.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).