From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A090AC432C0 for ; Wed, 20 Nov 2019 21:50:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B4EC20708 for ; Wed, 20 Nov 2019 21:50:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726568AbfKTVt7 (ORCPT ); Wed, 20 Nov 2019 16:49:59 -0500 Received: from imap1.codethink.co.uk ([176.9.8.82]:36430 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725819AbfKTVt7 (ORCPT ); Wed, 20 Nov 2019 16:49:59 -0500 Received: from [167.98.27.226] (helo=xylophone) by imap1.codethink.co.uk with esmtpsa (Exim 4.84_2 #1 (Debian)) id 1iXXrA-0005Bw-71; Wed, 20 Nov 2019 21:49:48 +0000 Message-ID: Subject: Re: [Y2038] [PATCH 3/8] powerpc: fix vdso32 for ppc64le From: Ben Hutchings To: Arnd Bergmann Cc: y2038 Mailman List , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev , "linux-kernel@vger.kernel.org" Date: Wed, 20 Nov 2019 21:49:47 +0000 In-Reply-To: References: <20191108203435.112759-1-arnd@arndb.de> <20191108203435.112759-4-arnd@arndb.de> Organization: Codethink Ltd. Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-11-20 at 20:35 +0100, Arnd Bergmann wrote: > On Wed, Nov 20, 2019 at 8:13 PM Ben Hutchings > wrote: > > On Fri, 2019-11-08 at 21:34 +0100, Arnd Bergmann wrote: > > > On little-endian 32-bit application running on 64-bit kernels, > > > the current vdso would read the wrong half of the xtime seconds > > > field. Change it to return the lower half like it does on > > > big-endian. > > > > ppc64le doesn't have 32-bit compat so this is only theoretical. > > That is probably true. I only looked at the kernel, which today still > supports compat mode for ppc64le, but I saw the patches to disable > it, and I don't think anyone has even attempted building user space > for it. COMPAT is still enabled for some reason, but VDSO32 isn't (since 4.2). Ben. -- Ben Hutchings, Software Developer Codethink Ltd https://www.codethink.co.uk/ Dale House, 35 Dale Street Manchester, M1 2HF, United Kingdom