linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Oliver O'Halloran <oohall@gmail.com>,
	Qiujun Huang <hqjagain@gmail.com>,
	linuxppc-dev@lists.ozlabs.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v3] powerpc/powernv: add NULL check after kzalloc in opal_add_one_export
Date: Mon, 6 Apr 2020 12:02:11 +0200	[thread overview]
Message-ID: <d8334f5d-403f-941f-abcc-2714d297082b@web.de> (raw)
In-Reply-To: <CAOSf1CGLZ5H1cUsv6atZ7hNpQ+PDyyAjp6dzJjXMwC5XoUOVQQ@mail.gmail.com>

>>>> Here needs a NULL check.
>> quite obvious?

I suggest to consider another fine-tuning for the wording also around
such “obvious” programming items.


>>> I find this change description questionable
>>> (despite of a reasonable patch subject).

I got further development concerns.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=a10c9c710f9ecea87b9f4bbb837467893b4bef01#n129

* Were changes mixed for different issues according to the diff code?

* I find it safer here to split specific changes into separate update steps
  for a small patch series.

* Will the addition of the desired null pointer check qualify for
  the specification of the tag “Fixes”?


>>> Will a patch change log be helpful here?
>> I realized I should write some change log, and the change log was meaningless.

Will any more adjustments happen for the discussed update suggestion
after the third patch version?


> The changelog is fine IMO. The point of a changelog is to tell a
> reader doing git archeology why a change happened and this is
> sufficent for that.

We might stumble on a different understanding for the affected “change logs”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=a10c9c710f9ecea87b9f4bbb837467893b4bef01#n751

Would you like to follow the patch evolution a bit easier?

Regards,
Markus

  parent reply	other threads:[~2020-04-06 10:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-05 19:06 [PATCH v3] powerpc/powernv: add NULL check after kzalloc in opal_add_one_export Markus Elfring
2020-04-06  1:13 ` Qiujun Huang
2020-04-06  9:01   ` Oliver O'Halloran
2020-04-06  9:23     ` Qiujun Huang
2020-04-06 10:02     ` Markus Elfring [this message]
2020-04-06 10:40       ` Qiujun Huang
  -- strict thread matches above, loose matches on Subject: below --
2020-04-05 12:25 Qiujun Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8334f5d-403f-941f-abcc-2714d297082b@web.de \
    --to=markus.elfring@web.de \
    --cc=benh@kernel.crashing.org \
    --cc=hqjagain@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=oohall@gmail.com \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).