From: Richard Gong <richard.gong@linux.intel.com>
To: Xu Yilun <yilun.xu@intel.com>, Moritz Fischer <mdf@kernel.org>
Cc: trix@redhat.com, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org, dinguyen@kernel.org,
sridhar.rajagopal@intel.com,
Richard Gong <richard.gong@intel.com>
Subject: Re: [PATCHv1 3/4] dt-bindings: fpga: add authenticate-fpga-config property
Date: Mon, 16 Nov 2020 08:14:52 -0600 [thread overview]
Message-ID: <d83b37c2-2baa-b366-8ca4-bb2924bcd4f9@linux.intel.com> (raw)
In-Reply-To: <20201116024758.GA6810@yilunxu-OptiPlex-7050>
Hi Yilun,
On 11/15/20 8:47 PM, Xu Yilun wrote:
> On Sun, Nov 15, 2020 at 11:21:06AM -0800, Moritz Fischer wrote:
>> Hi Richard,
>>
>> On Thu, Nov 12, 2020 at 12:06:42PM -0600, richard.gong@linux.intel.com wrote:
>>> From: Richard Gong <richard.gong@intel.com>
>>>
>>> Add authenticate-fpga-config property for FPGA bitstream authentication.
>>>
>>> Signed-off-by: Richard Gong <richard.gong@intel.com>
>>> ---
>>> Documentation/devicetree/bindings/fpga/fpga-region.txt | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/fpga/fpga-region.txt b/Documentation/devicetree/bindings/fpga/fpga-region.txt
>>> index e811cf8..7a512bc 100644
>>> --- a/Documentation/devicetree/bindings/fpga/fpga-region.txt
>>> +++ b/Documentation/devicetree/bindings/fpga/fpga-region.txt
>>> @@ -187,6 +187,7 @@ Optional properties:
>>> - external-fpga-config : boolean, set if the FPGA has already been configured
>>> prior to OS boot up.
>>> - encrypted-fpga-config : boolean, set if the bitstream is encrypted
>>> +- authenticate-fpga-config : boolean, set if do bitstream authentication
>> It is unclear to me from the description whether this entails
>> authentication + reconfiguration or just authentication.
>>
>> If the latter is the case this should probably be described as such.
>
> If it is just authentication, do we still need to disable bridges in
> fpga_region_program_fpga?
>
Yes.
Except for the actual configuration of the device, the authentication
feature is the same as FPGA configuration.
Regards,
Richard
> I'm wondering if the FPGA functionalities could still be working when
> the authenticating is ongoing, or when the authenticating is failed.
>
> Thanks,
> Yilun
>
>>
>>> - region-unfreeze-timeout-us : The maximum time in microseconds to wait for
>>> bridges to successfully become enabled after the region has been
>>> programmed.
>>> --
>>> 2.7.4
>>>
>>
>> Thanks
next prev parent reply other threads:[~2020-11-16 13:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 18:06 [PATCHv1 0/4] Extend FPGA manager and region drivers for richard.gong
2020-11-12 18:06 ` [PATCHv1 1/4] fpga: fpga-mgr: add FPGA_MGR_BITSTREM_AUTHENTICATION flag richard.gong
2020-11-13 20:24 ` Tom Rix
2020-11-14 14:30 ` Richard Gong
2020-11-14 15:53 ` Tom Rix
2020-11-16 13:39 ` Richard Gong
2020-11-12 18:06 ` [PATCHv1 2/4] fpga: of-fpga-region: add authenticate-fpga-config property richard.gong
2020-11-13 20:25 ` Tom Rix
2020-11-12 18:06 ` [PATCHv1 3/4] dt-bindings: fpga: " richard.gong
2020-11-13 20:28 ` Tom Rix
2020-11-14 14:52 ` Richard Gong
2020-11-14 15:59 ` Tom Rix
2020-11-16 13:50 ` Richard Gong
2020-11-16 15:11 ` Tom Rix
2020-11-15 19:21 ` Moritz Fischer
2020-11-16 2:47 ` Xu Yilun
2020-11-16 14:14 ` Richard Gong [this message]
2020-11-17 2:24 ` Xu Yilun
2020-11-17 15:39 ` Richard Gong
2020-11-18 5:47 ` Xu Yilun
2020-11-18 13:38 ` Richard Gong
2020-11-19 11:14 ` Xu Yilun
2020-11-16 13:59 ` Richard Gong
2020-11-12 18:06 ` [PATCHv1 4/4] fpga: stratix10-soc: entend driver for bitstream authentication richard.gong
2020-11-13 20:31 ` Tom Rix
2020-11-14 14:55 ` Richard Gong
2020-11-15 19:19 ` Moritz Fischer
2020-11-16 14:39 ` Richard Gong
2020-11-16 2:41 ` [PATCHv1 0/4] Extend FPGA manager and region drivers for Xu Yilun
2020-11-16 14:02 ` Richard Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d83b37c2-2baa-b366-8ca4-bb2924bcd4f9@linux.intel.com \
--to=richard.gong@linux.intel.com \
--cc=dinguyen@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=richard.gong@intel.com \
--cc=sridhar.rajagopal@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).