From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965270AbcIHMkr (ORCPT ); Thu, 8 Sep 2016 08:40:47 -0400 Received: from mout.web.de ([212.227.15.3]:61914 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935129AbcIHMkp (ORCPT ); Thu, 8 Sep 2016 08:40:45 -0400 From: SF Markus Elfring Subject: [PATCH] ATM-ENI: Use kmalloc_array() in eni_start() To: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, Chas Williams <3chas3@gmail.com> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini Message-ID: Date: Thu, 8 Sep 2016 14:40:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:HMtSI/9F0OztWb/3nobsVyx7YrmDllkuOB4K+G5cWIsWSAXBXOh yjVBi0HlWoHgJWiRXVbwUAA1BoWmW7dRYc+tQj5gsv1/DVYkLKEIqVgFqMOMFWsgYZzFP3Z EpmDZ6E750oXBCcsVNolv97e/3hHiAvSlFb5v34jDJ2smWGsKWHPZFXhs4InyD6C1wJsmEe RPObrwAUwuAlKfKSsNsOQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:mnnFJFf7SPg=:mB7C4TaF2worQXVgYpCOrB ZFKfkjXLEYDneiN/7XeY3LkSu6laLWfcWpx9on0UHt1csOPeNLqvrCK/o5UlSdh1gubpbt5pE QF9FAdh+d+yIegwnBA2fE7xcPOgW1LjShBqiShMcOJuiy8xhhhyfrEyF99BvYSWrVuANMKF20 WmKAyG+EUgku49M2hntD9VbFcVvOcL7M+4nkVsrKO7WQ2CIj3gNIY0WIv4zmUc4plNgH/s/Z/ OuIbwAYei8B4+zE1fUFz659pLDdy36GC9u41O5jdDBch0wkmMDH/CGbBh3H4ck0sYi2Wnu4mg zD+RxUPu+IT8lb4UCbcGLbjdr5iKdMJLgtw/EYe+iHVOJwaZGLfO8AmDCgw07/mLGV0h75STb 3GN7vYz1xZIPm47kZyZnC+Iii5Wl66RYZffbLkE5Z+xR4LB6JasqTEdPDIgZDH0BsTRYsU9RC BikbLmAMYcgh23xZdoqXJupdT1N5rTwAhebJmqogNPyCRBcWDl29RshYdmd8C1H+QK1FkkykU 3pLr2FJRTyg/bbPiglJvqA00VyO0BpAxc2S9BGfkwcnDaJ1TtwhEzf65f3DTHZJbGuYCaETRS aCxFwgt975xCoEOEQwQ1ZYjtF5qcmbr1ct/XEjtXYlCSCGR5N0NMWsAGk2AeA0LC5Gykjfnc1 U3N1xu+r7Tfaf/m7rFbRqrcg5AQW9d8YOb2PYoXO3m1vqHKrhe8DhEs1iYmavQ6ZAUNmnZhSm xm9xK0MwlZ8G8uVR2g29JmriGoLPElc0RJy2v4uKsaaShOr+EvBiWxLKeWUTbX7DVMPNVMDte tq0AfpU Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 8 Sep 2016 14:20:17 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/atm/eni.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c index 6339efd..f2aaf9e 100644 --- a/drivers/atm/eni.c +++ b/drivers/atm/eni.c @@ -1845,8 +1845,9 @@ static int eni_start(struct atm_dev *dev) /* initialize memory management */ buffer_mem = eni_dev->mem - (buf - eni_dev->ram); eni_dev->free_list_size = buffer_mem/MID_MIN_BUF_SIZE/2; - eni_dev->free_list = kmalloc( - sizeof(struct eni_free)*(eni_dev->free_list_size+1),GFP_KERNEL); + eni_dev->free_list = kmalloc_array(eni_dev->free_list_size + 1, + sizeof(*eni_dev->free_list), + GFP_KERNEL); if (!eni_dev->free_list) { printk(KERN_ERR DEV_LABEL "(itf %d): couldn't get free page\n", dev->number); -- 2.10.0