From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751416AbdALJWM (ORCPT ); Thu, 12 Jan 2017 04:22:12 -0500 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:53784 "EHLO gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751342AbdALJVk (ORCPT ); Thu, 12 Jan 2017 04:21:40 -0500 From: Chris Packham To: Sebastian Hesselbarth , Linus Walleij , Gregory CLEMENT , Thomas Petazzoni CC: "linux-arm-kernel@lists.infradead.org" , Kalyan Kinthada , Rob Herring , Mark Rutland , Laxman Dewangan , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCHv3 3/5] pinctrl: mvebu: pinctrl driver for 98DX3236 SoC Thread-Topic: [PATCHv3 3/5] pinctrl: mvebu: pinctrl driver for 98DX3236 SoC Thread-Index: AQHSZ9OUpHZVpAhXz0qJDiHTp4XU1Q== Date: Thu, 12 Jan 2017 09:13:44 +0000 Message-ID: References: <20170105033641.6212-1-chris.packham@alliedtelesis.co.nz> <20170106041517.9589-1-chris.packham@alliedtelesis.co.nz> <20170106041517.9589-4-chris.packham@alliedtelesis.co.nz> <95cb4240-e77b-5eaa-1920-4d9e26028038@gmail.com> Accept-Language: en-NZ, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.32.1.10] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0C9MWv6001787 On 12/01/17 09:56, Sebastian Hesselbarth wrote: > On 01/11/2017 03:44 PM, Linus Walleij wrote: >> On Fri, Jan 6, 2017 at 5:15 AM, Chris Packham >> wrote: >> >>> From: Kalyan Kinthada >>> >>> This pinctrl driver supports the 98DX3236, 98DX3336 and 98DX4251 SoCs >>> from Marvell. >>> >>> Signed-off-by: Kalyan Kinthada >>> Signed-off-by: Chris Packham >> >> I am waiting for an ACK or comment from the maintainers on >> this patch. Sebastian? > > Sorry for the ignorance. > > I don't have the patch to reply to inline, but: > > - In the driver MPP_MODE2, spi0 there is a typo "csk" instead of "sck". > - MPP_MODE5 binding "dev","bootcs" and driver "dev","bootcs0" differ. > - MPP_MODE6 binding "gpio" and driver "gpo" differ. > - MPP_MODE17 binding "dev","clk" and driver "dev","clkout" differ. > - MPP_MODE19 binding mentiones "dev","rb" but driver does not. > - MPP_MODE20 binding "gpio" and driver "gpo" differ. > - MPP_MODE20 binding "dev","we" and driver "dev","we0" differ. > - MPP_MODE21 through MPP_MODE30 binding "gpio" and driver "gpo" differ. > - remove spaces before "0, 0" in mv98dx3236_mpp_gpio_ranges. > > Most of it is cosmetic stuff, so if you fix it feel free to add my > > Acked-by: Sebastian Hesselbarth Hi Sebastian, Hopefully I can get a v4 out with the above fixed soon. One point on "gpio" vs "gpo" this one isn't a typo. Some of these pins can be driven as outputs but can't be used as inputs. From a pinctrl driver point of view there is no difference but I did want to convey that from a system design point of view if you really need something to be an input you shouldn't use one of these pins. This is also noted in the datasheets so it doesn't necessarily need repeating. If you still want me to use "gpio" in the code and binding I'm happy to do so.