From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AB82C5517A for ; Mon, 26 Oct 2020 09:13:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD605207C4 for ; Mon, 26 Oct 2020 09:13:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1772766AbgJZJN3 convert rfc822-to-8bit (ORCPT ); Mon, 26 Oct 2020 05:13:29 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]:22591 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1772752AbgJZJN1 (ORCPT ); Mon, 26 Oct 2020 05:13:27 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-5-wcDirhFCN4mn4PPcBzXjBQ-1; Mon, 26 Oct 2020 09:13:23 +0000 X-MC-Unique: wcDirhFCN4mn4PPcBzXjBQ-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 26 Oct 2020 09:13:23 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Mon, 26 Oct 2020 09:13:23 +0000 From: David Laight To: 'Stefano Garzarella' CC: Colin King , "David S . Miller" , Jakub Kicinski , "netdev@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] vsock: ratelimit unknown ioctl error message Thread-Topic: [PATCH] vsock: ratelimit unknown ioctl error message Thread-Index: AQHWqUY0CPRviIGx7UytnIgbPi7/0amltMKAgAPgtgCAAAejEA== Date: Mon, 26 Oct 2020 09:13:23 +0000 Message-ID: References: <20201023122113.35517-1-colin.king@canonical.com> <20201023140947.kurglnklaqteovkp@steredhat> <20201026084300.5ag24vck3zeb4mcz@steredhat> In-Reply-To: <20201026084300.5ag24vck3zeb4mcz@steredhat> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefano Garzarella > Sent: 26 October 2020 08:43 ... > >Isn't the canonical error for unknown ioctl codes -ENOTTY? > > > > Oh, thanks for pointing that out! > > I had not paid attention to the error returned, but looking at it I > noticed that perhaps the most appropriate would be -ENOIOCTLCMD. > In the ioctl syscall we return -ENOTTY, if the callback returns > -ENOIOCTLCMD. > > What do you think? It is 729 v 443 in favour of ENOTTY (based on grep). No idea where ENOIOCTLCMD comes from, but ENOTTY probably goes back to the early 1970s. The fact that the ioctl wrapper converts the value is a good hint that userspace expects ENOTTY. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)