From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] io_uring: fix error handling in io_queue_link_head
Date: Thu, 5 Dec 2019 07:09:39 -0700 [thread overview]
Message-ID: <d8bd2795-bd46-cad1-d78d-344d2df5a9f2@kernel.dk> (raw)
In-Reply-To: <d3151624354a37ec5510af32b00475574aa60aca.1575551692.git.asml.silence@gmail.com>
On 12/5/19 6:15 AM, Pavel Begunkov wrote:
> In case of an error io_submit_sqe() drops a request and continues
> without it, even if the request was a part of a link. Not only it
> doesn't cancel links, but also may execute wrong sequence of actions.
>
> Stop consuming sqes, and let the user handle errors.
Thanks, applied.
--
Jens Axboe
prev parent reply other threads:[~2019-12-05 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 13:15 [PATCH] io_uring: fix error handling in io_queue_link_head Pavel Begunkov
2019-12-05 14:09 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8bd2795-bd46-cad1-d78d-344d2df5a9f2@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).