From: Jens Axboe <axboe@kernel.dk>
To: "Holger Hoffstätte" <holger@applied-asynchrony.com>,
"Anchal Agarwal" <anchalag@amazon.com>
Cc: fllinden@amazon.com, sblbir@amazon.com, msw@amazon.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-wbt: Avoid lock contention and thundering herd issue in wbt_wait
Date: Wed, 22 Aug 2018 08:27:04 -0600 [thread overview]
Message-ID: <d8c171ce-6dfe-e9e5-5673-8443cfec5f01@kernel.dk> (raw)
In-Reply-To: <834649ab-62d6-bc7f-ec60-6c1654ea3f26@applied-asynchrony.com>
On 8/22/18 6:54 AM, Holger Hoffstätte wrote:
> On 08/22/18 06:10, Jens Axboe wrote:
>> [...]
>> If you have time, please look at the 3 patches I posted earlier today.
>> Those are for mainline, so should be OK :-)
>
> I'm just playing along at home but with those 3 I get repeatable
> hangs & writeback not starting at all, but curiously *only* on my btrfs
> device; for inexplicable reasons some other devices with ext4/xfs flush
> properly. Yes, that surprised me too, but it's repeatable.
> Now this may or may not have something to do with some of my in-testing
> patches for btrfs itself, but if I remove those 3 wbt fixes, everything
> is golden again. Not eager to repeat since it hangs sync & requires a
> hard reboot.. :(
> Just thought you'd like to know.
Thanks, that's very useful info! I'll see if I can reproduce that.
--
Jens Axboe
next prev parent reply other threads:[~2018-08-22 14:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180731213410.GA35291@kaos-source-ops-60001.pdx1.amazon.com>
2018-08-01 15:14 ` [PATCH] blk-wbt: Avoid lock contention and thundering herd issue in wbt_wait Jens Axboe
[not found] ` <20180801170603.GA32864@kaos-source-ops-60001.pdx1.amazon.com>
2018-08-01 22:09 ` Jens Axboe
2018-08-07 14:29 ` Jens Axboe
[not found] ` <20180807201247.GA21108@kaos-source-ops-60001.pdx1.amazon.com>
2018-08-07 20:39 ` Jens Axboe
[not found] ` <20180807211216.GA14371@kaos-source-ops-60001.pdx1.amazon.com>
2018-08-07 21:19 ` Jens Axboe
2018-08-20 16:36 ` Jens Axboe
2018-08-20 17:34 ` van der Linden, Frank
2018-08-20 19:08 ` Jens Axboe
2018-08-20 19:29 ` Jens Axboe
2018-08-20 20:19 ` van der Linden, Frank
2018-08-20 20:20 ` Jens Axboe
2018-08-20 22:42 ` Balbir Singh
2018-08-21 2:58 ` Jens Axboe
2018-08-22 3:20 ` Jens Axboe
[not found] ` <20180822040126.GA18736@kaos-source-ops-60001.pdx1.amazon.com>
2018-08-22 4:10 ` Jens Axboe
2018-08-22 12:54 ` Holger Hoffstätte
2018-08-22 14:27 ` Jens Axboe [this message]
2018-08-22 16:42 ` van der Linden, Frank
2018-08-22 17:30 ` Jens Axboe
[not found] ` <20180822202645.GA8025@kaos-source-ops-60001.pdx1.amazon.com>
2018-08-22 21:05 ` Jens Axboe
2018-08-22 17:28 ` Jens Axboe
2018-08-07 21:28 ` Matt Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8c171ce-6dfe-e9e5-5673-8443cfec5f01@kernel.dk \
--to=axboe@kernel.dk \
--cc=anchalag@amazon.com \
--cc=fllinden@amazon.com \
--cc=holger@applied-asynchrony.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msw@amazon.com \
--cc=sblbir@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).