From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932899AbcFQQEP (ORCPT ); Fri, 17 Jun 2016 12:04:15 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:49553 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755630AbcFQQEM (ORCPT ); Fri, 17 Jun 2016 12:04:12 -0400 Subject: Re: [PATCH V2 45/63] clocksource/drivers/timer-keystone: Convert init function to return error To: Daniel Lezcano , tglx@linutronix.de References: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> <1466112442-31105-46-git-send-email-daniel.lezcano@linaro.org> Cc: linux-kernel@vger.kernel.org, Santosh Shilimkar , "moderated list:ARM/TEXAS INSTRUM..." From: Santosh Shilimkar Organization: Oracle Corporation Message-ID: Date: Fri, 17 Jun 2016 09:03:36 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1466112442-31105-46-git-send-email-daniel.lezcano@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/16/2016 2:27 PM, Daniel Lezcano wrote: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and > make the system boot up correctly > > or > > - print an error and let the caller unaware if the state of the system > > Change that by converting the init functions to return an error conforming > to the CLOCKSOURCE_OF_RET prototype. > > Proper error handling (rollback, errno value) will be changed later case > by case, thus this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano > --- > drivers/clocksource/timer-keystone.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > Acked-by: Santosh Shilimkar