From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933079AbcFBPO2 (ORCPT ); Thu, 2 Jun 2016 11:14:28 -0400 Received: from zencphosting06.zen.co.uk ([82.71.204.9]:36622 "EHLO zencphosting06.zen.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932875AbcFBPOZ (ORCPT ); Thu, 2 Jun 2016 11:14:25 -0400 Subject: Re: [PATCH v3 0/8] Input: atmel_mxt_ts - output raw touch diagnostic data via V4L To: Dmitry Torokhov References: <1464799192-28034-1-git-send-email-nick.dyer@itdev.co.uk> <20160601181700.GD4114@dtor-ws> Cc: Hans Verkuil , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Benjamin Tissoires , Benson Leung , Alan Bowens , Javier Martinez Canillas , Chris Healy , Henrik Rydberg , Andrew Duggan , James Chen , Dudley Du , Andrew de los Reyes , sheckylin@chromium.org, Peter Hutterer , Florian Echtler , mchehab@osg.samsung.com From: Nick Dyer Message-ID: Date: Thu, 2 Jun 2016 16:14:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160601181700.GD4114@dtor-ws> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-OutGoing-Spam-Status: No, score=-1.5 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - zencphosting06.zen.co.uk X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - itdev.co.uk X-Get-Message-Sender-Via: zencphosting06.zen.co.uk: authenticated_id: nick.dyer@itdev.co.uk X-Authenticated-Sender: zencphosting06.zen.co.uk: nick.dyer@itdev.co.uk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry- On 01/06/2016 19:17, Dmitry Torokhov wrote: > On Wed, Jun 01, 2016 at 05:39:44PM +0100, Nick Dyer wrote: >> This is a series of patches to add diagnostic data support to the Atmel >> maXTouch driver. It's a rewrite of the previous implementation which output via >> debugfs: it now uses a V4L2 device in a similar way to the sur40 driver. > > I do not have any objections other than some nits form the input side; > majority of the review should come from V4L2 side here... Thanks for the review. I've hopefully fixed the issues you raised and pushed it to https://github.com/ndyer/linux/commits/diagnostic-v4l-20160602 I will wait for the V4L2 folks to comment before posting a [PATCH v4] cheers Nick