From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 971B8C433E3 for ; Sat, 22 Aug 2020 05:21:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F82420724 for ; Sat, 22 Aug 2020 05:21:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726531AbgHVFVe (ORCPT ); Sat, 22 Aug 2020 01:21:34 -0400 Received: from mga07.intel.com ([134.134.136.100]:31199 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725811AbgHVFVd (ORCPT ); Sat, 22 Aug 2020 01:21:33 -0400 IronPort-SDR: /tgECFdLSz61qZ4rt/WqgVHIIGVNmxu8azP01t3xuApMr09oFS7l8wOcmpIN8WKrqZMWqqV/Ui jkF0KmEewaEA== X-IronPort-AV: E=McAfee;i="6000,8403,9720"; a="219954727" X-IronPort-AV: E=Sophos;i="5.76,339,1592895600"; d="scan'208";a="219954727" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2020 22:21:33 -0700 IronPort-SDR: w+1lVZezxPiYtIAfwBALW9KJ6hUs7BWHPRIy8uzlAaArGVbklPYIzdYbBPISVJZxENsW3sWluk sE62Ty4DVTCA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,339,1592895600"; d="scan'208";a="311634014" Received: from linux.intel.com ([10.54.29.200]) by orsmga002.jf.intel.com with ESMTP; 21 Aug 2020 22:21:33 -0700 Received: from [10.214.149.112] (rtanwar-MOBL.gar.corp.intel.com [10.214.149.112]) by linux.intel.com (Postfix) with ESMTP id C15CE58081E; Fri, 21 Aug 2020 22:21:29 -0700 (PDT) Subject: Re: [PATCH v9 2/2] Add PWM fan controller driver for LGM SoC To: Andy Shevchenko Cc: u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org, lee.jones@linaro.org, thierry.reding@gmail.com, p.zabel@pengutronix.de, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, songjun.Wu@intel.com, cheol.yong.kim@intel.com, qi-ming.wu@intel.com, rahul.tanwar.linux@gmail.com, rtanwar@maxlinear.com References: <20200821105618.GO1891694@smile.fi.intel.com> From: "Tanwar, Rahul" Message-ID: Date: Sat, 22 Aug 2020 13:21:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200821105618.GO1891694@smile.fi.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On 21/8/2020 6:56 pm, Andy Shevchenko wrote: > On Fri, Aug 21, 2020 at 05:32:11PM +0800, Rahul Tanwar wrote: >> Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. >> This PWM controller does not have any other consumer, it is a >> dedicated PWM controller for fan attached to the system. Add >> driver for this PWM fan controller. > ... > >> +#include >> +#include >> +#include >> +#include > We haven't settle this yet... I investigated more about it. I was getting build error because we were relying on of_device.h for including platform_device.h. You are right that we are not using anything from of_device.h. So i removed of_device.h from driver and added include & build is ok. Regarding mod_devicetable.h header, it gets included indirectly from which includes of.h which includes mod_devicetable.h. So i think no point including it again in the driver. Regards, Rahul >> +#include >> +#include >> +#include