From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B643DC49EA6 for ; Wed, 23 Jun 2021 21:33:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9AB26613AD for ; Wed, 23 Jun 2021 21:33:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229900AbhFWVfd (ORCPT ); Wed, 23 Jun 2021 17:35:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24997 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229759AbhFWVfc (ORCPT ); Wed, 23 Jun 2021 17:35:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624483994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PFYcdOACUL59Qvc4FRYngRxPwSqQBpDBN6EEDPGjjUk=; b=CYju/gXKj/EfVHb5hklqFEi4d9A0sVMTpptFzz255eUKwJMdK8HdvTaxnsFN8iACC2P7Cw mDMk0+pcAM4a0L8FOn8hMybdnQ9FLcnKtO+OGkOUjN+131QJr7m7b26wvyc/WrlNnnVfF6 lLXnUoYe/A9FlblOQNQ9hDyWkbNGPPo= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-162-Zn9qba8AP6ykJCCO-te7Bw-1; Wed, 23 Jun 2021 17:33:12 -0400 X-MC-Unique: Zn9qba8AP6ykJCCO-te7Bw-1 Received: by mail-ej1-f71.google.com with SMTP id k1-20020a17090666c1b029041c273a883dso1441427ejp.3 for ; Wed, 23 Jun 2021 14:33:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PFYcdOACUL59Qvc4FRYngRxPwSqQBpDBN6EEDPGjjUk=; b=CWN62gUwjcf0JlFEnzeh9DxZh1vNLLchKdbiKHRhgskHXhE2w1sUf2dqyji21GoOQV 0HlhD5SDrDJEkKPbYAwdUFcRphSj1GQutsvVY3XFiprGQ3We0wPePy9fWNj4xSYpKBv4 1Jn4CPfC8XHrEYS2pt7pbdulWilRroD81/HVdNk7QDPiW4CI1w19MqXhkJo5yJfXYfGU daPS0dUMKsRfShvbXkFVVd7VLyzioKHkJt3725fqsTQhSeawdtyks0nA/I0v7Ka5x640 8DZYZ0KvbMJ9cjuv6ZNLh9snWOLXGJzsqCygHzbMRSTnsel95m+oZ8Vl8/Bu3rBlx/3k u7cw== X-Gm-Message-State: AOAM530iCW09h29XvNGkBGcZEVlJOtpcSxVebDeOyklQ6KgYtql1I8g8 y7jfByaevdasWDaWMzTM1QGhQTyEIqv8Il43Fy7YVkUMaBod4R1WmcjQQrqe8+eHiJ5O4LsSkmx QNE8rdqDNPHhhrBAjNy6hS2NG X-Received: by 2002:a05:6402:31a9:: with SMTP id dj9mr2459677edb.164.1624483991666; Wed, 23 Jun 2021 14:33:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7loBBFqTPbXnGVrSMX7KEDA1IKgrhU2wGwS08VkIiayRVDOaVyT3cWE10La9bhIXhoN+FnQ== X-Received: by 2002:a05:6402:31a9:: with SMTP id dj9mr2459667edb.164.1624483991509; Wed, 23 Jun 2021 14:33:11 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id p13sm662608edh.79.2021.06.23.14.33.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jun 2021 14:33:10 -0700 (PDT) Subject: Re: [PATCH 00/54] KVM: x86/mmu: Bug fixes and summer cleaning To: Sean Christopherson Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Yu Zhang , Maxim Levitsky References: <20210622175739.3610207-1-seanjc@google.com> From: Paolo Bonzini Message-ID: Date: Wed, 23 Jun 2021 23:33:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/06/21 23:06, Sean Christopherson wrote: >> >> This is good stuff, I made a few comments but almost all of them (all except >> the last comment on patch 9, "Unconditionally zap unsync SPs") are cosmetic >> and I can resolve them myself. > The 0-day bot also reported some warnings. vcpu_to_role_regs() needs to be > static, the helpers are added without a user. I liked the idea of adding the > helpers in one patch, but I can't really defend adding them without a user. :-/ Yep, I noticed them too. We can just mark them static inline, which is a good idea anyway and enough to shut up the compiler (clang might behave different in this respect for .h and .c files, but again it's just a warning and not a bisection breakage). Paolo > arch/x86/kvm/mmu/mmu.c:209:26: warning: no previous prototype for function 'vcpu_to_role_regs' [-Wmissing-prototypes] > struct kvm_mmu_role_regs vcpu_to_role_regs(struct kvm_vcpu *vcpu) > ^ > arch/x86/kvm/mmu/mmu.c:209:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > struct kvm_mmu_role_regs vcpu_to_role_regs(struct kvm_vcpu *vcpu) > ^ > static > arch/x86/kvm/mmu/mmu.c:199:1: warning: unused function '____is_cr0_wp' [-Wunused-function] > BUILD_MMU_ROLE_REGS_ACCESSOR(cr0, wp, X86_CR0_WP); >