From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
To: Dave Hansen <dave.hansen@intel.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Cc: rkrcmar@redhat.com, x86@kernel.org, mingo@redhat.com,
bp@alien8.de, hpa@zytor.com, pbonzini@redhat.com,
tglx@linutronix.de, akpm@linux-foundation.org
Subject: Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints
Date: Mon, 04 Feb 2019 12:42:22 -0800 [thread overview]
Message-ID: <d921273395b236bbc07bd7abd0359108b819448c.camel@linux.intel.com> (raw)
In-Reply-To: <24277842-c920-4a12-57d1-2ebcdf3c1534@intel.com>
On Mon, 2019-02-04 at 11:44 -0800, Dave Hansen wrote:
> On 2/4/19 10:15 AM, Alexander Duyck wrote:
> > +#ifdef CONFIG_KVM_GUEST
> > +#include <linux/jump_label.h>
> > +extern struct static_key_false pv_free_page_hint_enabled;
> > +
> > +#define HAVE_ARCH_FREE_PAGE
> > +void __arch_free_page(struct page *page, unsigned int order);
> > +static inline void arch_free_page(struct page *page, unsigned int order)
> > +{
> > + if (static_branch_unlikely(&pv_free_page_hint_enabled))
> > + __arch_free_page(page, order);
> > +}
> > +#endif
>
> So, this ends up with at least a call, a branch and a ret added to the
> order-0 paths, including freeing pages to the per-cpu-pageset lists.
> That seems worrisome.
>
> What performance testing has been performed to look into the overhead
> added to those paths?
So far I haven't done much in the way of actual performance testing.
Most of my tests have been focused on "is this doing what I think it is
supposed to be doing".
I have been debating if I want to just move the order checks to include
them in the inline functions. In that case we would end up essentially
just jumping over the call code.
next prev parent reply other threads:[~2019-02-04 20:42 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 18:15 [RFC PATCH 0/4] kvm: Report unused guest pages to host Alexander Duyck
2019-02-04 18:15 ` [RFC PATCH 1/4] madvise: Expose ability to set dontneed from kernel Alexander Duyck
2019-02-04 18:15 ` [RFC PATCH 2/4] kvm: Add host side support for free memory hints Alexander Duyck
2019-02-10 0:44 ` Michael S. Tsirkin
2019-02-11 17:34 ` Alexander Duyck
2019-02-11 17:36 ` Michael S. Tsirkin
2019-02-11 17:41 ` Dave Hansen
2019-02-11 17:48 ` Michael S. Tsirkin
2019-02-11 18:30 ` Alexander Duyck
2019-02-11 19:24 ` Michael S. Tsirkin
2019-02-04 18:15 ` [RFC PATCH 3/4] kvm: Add guest " Alexander Duyck
2019-02-04 19:44 ` Dave Hansen
2019-02-04 20:42 ` Alexander Duyck [this message]
2019-02-04 23:00 ` Nadav Amit
2019-02-04 23:37 ` Alexander Duyck
2019-02-05 0:03 ` Nadav Amit
2019-02-05 0:16 ` Alexander Duyck
2019-02-05 1:46 ` Nadav Amit
2019-02-05 18:09 ` Alexander Duyck
2019-02-07 18:21 ` Luiz Capitulino
2019-02-07 18:44 ` Alexander Duyck
2019-02-07 20:02 ` Luiz Capitulino
2019-02-08 21:05 ` Nitesh Narayan Lal
2019-02-08 21:31 ` Alexander Duyck
2019-02-10 0:49 ` Michael S. Tsirkin
2019-02-11 16:31 ` Alexander Duyck
2019-02-11 17:36 ` Michael S. Tsirkin
2019-02-11 18:10 ` Alexander Duyck
2019-02-11 19:54 ` Michael S. Tsirkin
2019-02-11 21:00 ` Alexander Duyck
2019-02-11 22:52 ` Michael S. Tsirkin
[not found] ` <94462313ccd927d25675f69de459456cf066c1a2.camel@linux.intel.com>
2019-02-12 0:34 ` Michael S. Tsirkin
2019-02-11 17:48 ` Dave Hansen
2019-02-11 17:58 ` Michael S. Tsirkin
2019-02-11 18:19 ` Dave Hansen
2019-02-11 19:56 ` Michael S. Tsirkin
2019-02-04 18:15 ` [RFC PATCH 4/4] mm: Add merge page notifier Alexander Duyck
2019-02-04 19:40 ` Dave Hansen
2019-02-04 19:51 ` Alexander Duyck
2019-02-10 0:57 ` Michael S. Tsirkin
2019-02-11 13:30 ` Nitesh Narayan Lal
2019-02-11 14:17 ` Michael S. Tsirkin
2019-02-11 16:24 ` Nitesh Narayan Lal
2019-02-11 17:41 ` Michael S. Tsirkin
2019-02-11 18:09 ` Nitesh Narayan Lal
2019-02-11 6:40 ` Aaron Lu
2019-02-11 15:58 ` Alexander Duyck
2019-02-12 2:09 ` Aaron Lu
2019-02-12 17:20 ` Alexander Duyck
2019-02-04 18:19 ` [RFC PATCH QEMU] i386/kvm: Enable paravirtual unused page hint mechanism Alexander Duyck
2019-02-05 17:25 ` [RFC PATCH 0/4] kvm: Report unused guest pages to host Nitesh Narayan Lal
2019-02-05 18:43 ` Alexander Duyck
2019-02-07 14:48 ` Nitesh Narayan Lal
2019-02-07 16:56 ` Alexander Duyck
2019-02-10 0:51 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d921273395b236bbc07bd7abd0359108b819448c.camel@linux.intel.com \
--to=alexander.h.duyck@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).