From: Guenter Roeck <linux@roeck-us.net>
To: Alexandre Torgue <alexandre.torgue@st.com>,
Ludovic BARRE <ludovic.barre@st.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Rob Herring <robh+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1
Date: Mon, 25 Jun 2018 06:15:35 -0700 [thread overview]
Message-ID: <d92ec883-09ae-271f-69dd-156df17c3e98@roeck-us.net> (raw)
In-Reply-To: <b5f62568-ff2f-4a04-212e-a952bf009c88@st.com>
On 06/25/2018 05:52 AM, Alexandre Torgue wrote:
> Hi Guenter,
>
>
>>> But you are right I forgot to change stm32f429.dtsi.
>>> If I add a commit for stm32f429.dtsi, it's Ok for you ?
>>>
>>
>> Not really. You are imposing a personal preference on others,
>> and you would make stm32f429.dtsi inconsistent since it doesn't
>> use clock names for anything else.This in turn means that people
>> will have an endless source of irritation since they will need
>> a clock name for this node but not for others.
>
> Why? This kind of implementation depends on each driver. Isn't ?
>
> Or do you mean that if iwdg driver uses this implementation (clock name usage) all nodes inside stm32f429.dtsi should follow the same implementation ?
>
>>
>> You will have to get the arm and DT maintainers to agree on this change.
>
> As this patch makes easier integration of new platform, I agree with Ludovic proposition.
>
Please provide a formal Acked-by:.
Guenter
next prev parent reply other threads:[~2018-06-25 13:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 9:02 [PATCH V4 0/4] add iwdg2 support for stm32mp157c Ludovic Barre
2018-06-21 9:02 ` [PATCH V4 1/4] dt-bindings: watchdog: add stm32mp1 support Ludovic Barre
2018-06-25 15:51 ` Rob Herring
2018-06-21 9:02 ` [PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1 Ludovic Barre
2018-06-21 16:53 ` Guenter Roeck
2018-06-22 9:15 ` Ludovic BARRE
2018-06-22 13:40 ` Guenter Roeck
2018-06-25 12:52 ` Alexandre Torgue
2018-06-25 13:15 ` Guenter Roeck [this message]
2018-06-25 15:04 ` Alexandre Torgue
2018-06-21 9:02 ` [PATCH V4 3/4] ARM: dts: stm32: add iwdg2 support for stm32mp157c Ludovic Barre
2018-06-21 9:02 ` [PATCH V4 4/4] ARM: dts: stm32: add iwdg2 support for stm32mp157c-ed1 Ludovic Barre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d92ec883-09ae-271f-69dd-156df17c3e98@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=ludovic.barre@st.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).