From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E9FC433DB for ; Tue, 22 Dec 2020 09:09:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A238B22AAA for ; Tue, 22 Dec 2020 09:09:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726033AbgLVJJK (ORCPT ); Tue, 22 Dec 2020 04:09:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725783AbgLVJJI (ORCPT ); Tue, 22 Dec 2020 04:09:08 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D895C0613D3 for ; Tue, 22 Dec 2020 01:08:28 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1krdec-0001OJ-Na; Tue, 22 Dec 2020 10:08:26 +0100 Subject: Re: Correct ordering of phy_init and phy_power_on To: Kishon Vijay Abraham I , Vinod Koul , Minas Harutyunyan , linux-usb@vger.kernel.org Cc: "linux-kernel@vger.kernel.org" , Pengutronix Kernel Team , Jules Maselbas References: <6cd01e79-fdc0-3bd4-32b5-a85142533f8a@pengutronix.de> <014e75a5-ab7b-55be-e554-14ef7550b360@ti.com> From: Ahmad Fatoum Message-ID: Date: Tue, 22 Dec 2020 10:08:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <014e75a5-ab7b-55be-e554-14ef7550b360@ti.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Kishon, On 21.12.20 04:15, Kishon Vijay Abraham I wrote: >> So how was it meant to be? > > It is intended to be ->init() and then ->power_on(). So ideally it > should be the way dwc3 is. Thanks. Should we do something about the inconsistency? Amend documentation and maybe print a warning when order is wrong, so users are encouraged to fix their drivers? The way it is, you can't properly mix some of the PHY and USB controller drivers. Cheers, Ahmad > > Thanks, > Kishon > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |