From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3274DC43441 for ; Fri, 23 Nov 2018 06:51:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD21A20863 for ; Fri, 23 Nov 2018 06:51:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="A4o9qMBv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD21A20863 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502168AbeKWReo (ORCPT ); Fri, 23 Nov 2018 12:34:44 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:36409 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393326AbeKWRem (ORCPT ); Fri, 23 Nov 2018 12:34:42 -0500 Received: by mail-wr1-f67.google.com with SMTP id t3so11234443wrr.3 for ; Thu, 22 Nov 2018 22:51:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8fRs6K7Qo+Olips1i1eYdvrYuqy7YjLDebXbeK3WRmo=; b=A4o9qMBvIfFNsmKWBbQvV3jPZ7SUxozomE/Wszp157wFFXo+kgbCFBjCtQe4m1z/Bh 6A4lYS+74Pbp5xcWCo7KMpo6lKH2Paq4FFYL+lnUL56bSYNN5iRP3DnKYYxCuB9q78bT BzUQHOYaS6u08vRlrMzA/AICo+hE7rfDVpj+Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8fRs6K7Qo+Olips1i1eYdvrYuqy7YjLDebXbeK3WRmo=; b=e/lLF7Udr+/PjzwmhLVJZ5Rm+kEVxPWzRJ8A4cata13Yp8/s02czGo5rfN/KCd/f+3 FSNoUA/iEnCpZneVYb8lXCrX9lkbYL1Cf2FzJvIDDqHptASy+BueNAeS2SrwuDGKRKmG P8L6rhjbHIT2H8KdVokunAsYzSUGT3XPXf0wDizAn5bsaljbLHTOTnUrNz6AWfuWKIoz MTiY7fQCTeNGyXg6e1NjWQGbPZCe9LqM5gHCgGZeA2wp26xOwyx9jJezzoR1Qrv+Wtrb i0L2DvtjV+ELxV77o9tz2eKV4xTudBD75mKhfb3S1AYyuz5R+crjZkARgZDvS37RmW0t CRBQ== X-Gm-Message-State: AA+aEWbR4NvvfOaqFt9KvKRjtjvt8pNUc/+JW5J0/k/dVW4MqNy6EDi0 k14QDTz/BYPgh1aQ+ysi1jx/VqpEa/A= X-Google-Smtp-Source: AFSGD/VXFEShY2EtI4n5n5JJ5QWfjczZ6RtyGQorsBVfO87E3ft3PKs47SX2F5Ia6/xXiCWUCiSMUw== X-Received: by 2002:adf:e846:: with SMTP id d6mr12941071wrn.72.1542955905598; Thu, 22 Nov 2018 22:51:45 -0800 (PST) Received: from [192.168.0.40] (44.65.136.77.rev.sfr.net. [77.136.65.44]) by smtp.googlemail.com with ESMTPSA id b131sm8654436wma.21.2018.11.22.22.51.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Nov 2018 22:51:44 -0800 (PST) Subject: Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails To: Wei Ni , thierry.reding@gmail.com, linux-tegra@vger.kernel.org Cc: rui.zhang@intel.com, edubezval@gmail.com, linux-kernel@vger.kernel.org References: <1542103567-5521-1-git-send-email-wni@nvidia.com> <1542103567-5521-2-git-send-email-wni@nvidia.com> <70f08208-d04c-c9a4-07e6-d377c33a9386@nvidia.com> <5e09bc13-7880-40f2-3f90-01d2cc3510ba@nvidia.com> <299fc8a0-39e4-1bd9-821b-4712a7f25028@linaro.org> <2f5d3135-6a25-82ce-cf3a-d804484644a1@nvidia.com> From: Daniel Lezcano Message-ID: Date: Fri, 23 Nov 2018 07:51:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <2f5d3135-6a25-82ce-cf3a-d804484644a1@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi wei, On 23/11/2018 07:15, Wei Ni wrote: > > > On 22/11/2018 9:07 PM, Daniel Lezcano wrote: >> On 22/11/2018 08:10, Wei Ni wrote: >>> >>> >>> On 21/11/2018 8:51 PM, Daniel Lezcano wrote: >>>> On 21/11/2018 11:23, Wei Ni wrote: >>>>> >>>>> >>>>> On 21/11/2018 4:55 PM, Daniel Lezcano wrote: >>>>>> On 13/11/2018 11:06, Wei Ni wrote: >>>>>>> Don't bail when a sensor fails to register with the >>>>>>> thermal zone and allow other sensors to register. >>>>>>> This allows other sensors to register with thermal >>>>>>> framework even if one sensor fails registration. >>>>>> >>>>>> I'm not sure if ignoring the error is really safe. Can you describe the >>>>>> real situation you want to overcome ? How do you differentiate critical >>>>>> sensors ? >>>>> >>>>> The driver will always try to register 4 thermal zones, including cpu, >>>>> gpu, mem and pll, but if the dts file doesn't set the corresponding >>>>> sensors, then the register will be failed. >>>>> Normally, the dts file will set all 4 sensors, but there may have some >>>>> platform doesn't support them all. So we post this patch. >>>> >>>> Ignoring errors is not the way to go to support different platforms. Fix >>>> the DT. >>> >>> The issue isn't in DT file. The Tegra soc thermal include 4 sensors: >>> cpu, gpu, mem, pll. But in some platforms, for example, we may only need >>> to support 2 sensors, such as cpu and gpu, so we only configure these >>> two senors in DT file. But the driver will always try to register 4 >>> sensors, cpu/gpu/mem/pll, so mem and pll will be registered failed. So >>> in this case we need to ignoring the failure, and continue to enable the >>> driver. >> >> You can fix this by changing the driver to support the platform and >> register the sensor you are interested in. >> >> Ignoring errors is not a good idea. > > If hit the errors, the driver will print out the warning. In current > code, the driver probe routine will return failure directly, indeed it > didn't do anything either except print out warnings. > I think this error should not block other sensors' registration. Let's > consider this case, we have four sensors, if the one sensor register > failed, then the driver return probe failure, so the drive will not be > enabled, and other sensor can't work either, it mean the device may boot > up without any thermal sensors. > Or if the error is the -ENODEV, that mean the we didn't set > corresponding sensor id in the dt file, so we can continue to register. > If the error is other value, then we can return directly. It is a possibility but may be there are a couple of alternatives: 1. If there is a compatible string for the platform variant, use it to probe the right sensors or 2. Use the qoriq driver approach by reparsing the DT and find out the thermal zone and their respective sensor id. >>>>> BTW, what do you mean "critical sensors"? We will set critical trip temp >>>>> for all sensors. >>>> >>>> I meant sensor for thermal zone getting really high temperature. >>> >>> We doesn't have the critical sensors. We set the critical trip temp for >>> all registered sensors. And these trip temp is set to the Tegra >>> hardware. So it mean if the temperature reached the critical trip point, >>> then the system will be shutdown directly. >>> >>>> >>>> >>>>>>> Signed-off-by: Wei Ni >>>>>>> --- >>>>>>> drivers/thermal/tegra/soctherm.c | 8 +++++--- >>>>>>> 1 file changed, 5 insertions(+), 3 deletions(-) >>>>>>> >>>>>>> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c >>>>>>> index ed28110a3535..a824d2e63af3 100644 >>>>>>> --- a/drivers/thermal/tegra/soctherm.c >>>>>>> +++ b/drivers/thermal/tegra/soctherm.c >>>>>>> @@ -1370,9 +1370,9 @@ static int tegra_soctherm_probe(struct platform_device *pdev) >>>>>>> &tegra_of_thermal_ops); >>>>>>> if (IS_ERR(z)) { >>>>>>> err = PTR_ERR(z); >>>>>>> - dev_err(&pdev->dev, "failed to register sensor: %d\n", >>>>>>> - err); >>>>>>> - goto disable_clocks; >>>>>>> + dev_warn(&pdev->dev, "failed to register sensor %s: %d\n", >>>>>>> + soc->ttgs[i]->name, err); >>>>>>> + continue; >>>>>>> } >>>>>>> >>>>>>> zone->tz = z; >>>>>>> @@ -1434,6 +1434,8 @@ static int __maybe_unused soctherm_resume(struct device *dev) >>>>>>> struct thermal_zone_device *tz; >>>>>>> >>>>>>> tz = tegra->thermctl_tzs[soc->ttgs[i]->id]; >>>>>>> + if (!tz) >>>>>>> + continue; >>>>>>> err = tegra_soctherm_set_hwtrips(dev, soc->ttgs[i], tz); >>>>>>> if (err) { >>>>>>> dev_err(&pdev->dev, >>>>>>> >>>>>> >>>>>> >>>> >>>> >> >> -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog