From: Akhil P Oommen <akhilpo@codeaurora.org>
To: Jonathan Marek <jonathan@marek.ca>, freedreno@lists.freedesktop.org
Cc: devicetree@vger.kernel.org, saravanak@google.com,
linux-arm-msm@vger.kernel.org, smasetty@codeaurora.org,
linux-kernel@vger.kernel.org, mka@chromium.org,
dri-devel@freedesktop.org, viresh.kumar@linaro.org,
sibis@codeaurora.org
Subject: Re: [PATCH v4 3/7] drm: msm: a6xx: set gpu freq through hfi
Date: Sat, 11 Jul 2020 04:06:41 +0530 [thread overview]
Message-ID: <d9875eae-d7e5-e091-4f3d-b279157ac1c1@codeaurora.org> (raw)
In-Reply-To: <40f6df1d-f524-c612-9215-591fd7f16e3b@codeaurora.org>
On 7/11/2020 2:43 AM, Akhil P Oommen wrote:
>
> On 7/10/2020 1:34 AM, Jonathan Marek wrote:
>> On 7/9/20 4:00 PM, Akhil P Oommen wrote:
>>> Newer targets support changing gpu frequency through HFI. So
>>> use that wherever supported instead of the legacy method.
>>>
>>
>> It was already using HFI on newer targets. Don't break it in one
>> commit then fix it in the next.
>
> Oops. I somehow got confused. Will fix and resend.
>
> -Akhil
I broke the pm_runtime_get_if_in_use() check too. Other than that, just
squashing this patch with the previous one should be enough.
-Akhil.
>
>>
>>> Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org>
>>> ---
>>> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 11 +++++++----
>>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
>>> b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
>>> index 233afea..b547339 100644
>>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
>>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
>>> @@ -121,6 +121,12 @@ void a6xx_gmu_set_freq(struct msm_gpu *gpu,
>>> struct dev_pm_opp *opp)
>>> if (gpu_freq == gmu->gpu_freqs[perf_index])
>>> break;
>>> + if (!gmu->legacy) {
>>> + a6xx_hfi_set_freq(gmu, gmu->current_perf_index);
>>> + icc_set_bw(gpu->icc_path, 0, MBps_to_icc(7216));
>>> + return;
>>> + }
>>> +
>>> gmu->current_perf_index = perf_index;
>>> gmu->freq = gmu->gpu_freqs[perf_index];
>>> @@ -893,10 +899,7 @@ int a6xx_gmu_resume(struct a6xx_gpu *a6xx_gpu)
>>> enable_irq(gmu->hfi_irq);
>>> /* Set the GPU to the current freq */
>>> - if (gmu->legacy)
>>> - a6xx_gmu_set_initial_freq(gpu, gmu);
>>> - else
>>> - a6xx_hfi_set_freq(gmu, gmu->current_perf_index);
>>> + a6xx_gmu_set_initial_freq(gpu, gmu);
>>> /*
>>> * "enable" the GX power domain which won't actually do
>>> anything but it
>>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-10 22:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 20:00 [PATCH v4 0/7] Add support for GPU DDR BW scaling Akhil P Oommen
2020-07-09 20:00 ` [PATCH v4 1/7] dt-bindings: drm/msm/gpu: Document gpu opp table Akhil P Oommen
2020-07-09 20:00 ` [PATCH v4 2/7] drm: msm: a6xx: send opp instead of a frequency Akhil P Oommen
2020-07-09 20:00 ` [PATCH v4 3/7] drm: msm: a6xx: set gpu freq through hfi Akhil P Oommen
2020-07-09 20:04 ` Jonathan Marek
2020-07-10 21:13 ` Akhil P Oommen
2020-07-10 22:36 ` Akhil P Oommen [this message]
2020-07-09 20:00 ` [PATCH v4 4/7] drm: msm: a6xx: use dev_pm_opp_set_bw to scale DDR Akhil P Oommen
2020-07-10 19:41 ` [Freedreno] " Rob Clark
2020-07-10 21:03 ` Akhil P Oommen
2020-07-10 22:32 ` Rob Clark
2020-07-09 20:00 ` [PATCH v4 5/7] arm64: dts: qcom: SDM845: Enable GPU DDR bw scaling Akhil P Oommen
2020-07-09 20:00 ` [PATCH v4 6/7] arm64: dts: qcom: sc7180: Add interconnects property for GPU Akhil P Oommen
2020-07-09 20:00 ` [PATCH v4 7/7] arm64: dts: qcom: sc7180: Add opp-peak-kBps to GPU opp Akhil P Oommen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9875eae-d7e5-e091-4f3d-b279157ac1c1@codeaurora.org \
--to=akhilpo@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=saravanak@google.com \
--cc=sibis@codeaurora.org \
--cc=smasetty@codeaurora.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).