From: "Ramuthevar, Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: kishon@ti.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, cheol.yong.kim@intel.com,
qi-ming.wu@intel.com, peter.harliman.liem@intel.com
Subject: Re: [PATCH v2 2/2] phy: intel-lgm-emmc: Add support for eMMC PHY
Date: Wed, 21 Aug 2019 13:34:19 +0800 [thread overview]
Message-ID: <d9a793ae-e66c-a6ae-ab05-d253b8eb27d7@linux.intel.com> (raw)
In-Reply-To: <20190820135921.GO30120@smile.fi.intel.com>
On 20/8/2019 9:59 PM, Andy Shevchenko wrote:
> On Tue, Aug 20, 2019 at 04:56:02PM +0300, Andy Shevchenko wrote:
>> On Tue, Aug 20, 2019 at 06:31:33PM +0800, Ramuthevar,Vadivel MuruganX wrote:
>>> +#define DR_TY_50OHM(x) ((~(x) << 28) & DR_TY_MASK)
>> For consistency it should be
>>
>> #define DR_TY_SHIFT(x) (((x) << 28) & DR_TY_MASK)
>>
>> with explanation about 50 Ohm in the code below.
>>> + /* Drive impedance: 50 Ohm */
>> Nice, you have already a comment here. Just use DR_TY_SHIFT(1)
> It should be DR_TY_SHIFT(6) now since I dropped the negation.
Thanks Andy, will update the review comments.
Best Regards
Vadivel
next prev parent reply other threads:[~2019-08-21 5:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 10:31 [PATCH v2 1/2] dt-bindings: phy: intel-emmc-phy: Add YAML schema for LGM eMMC PHY Ramuthevar,Vadivel MuruganX
2019-08-20 10:31 ` [PATCH v2 2/2] phy: intel-lgm-emmc: Add support for " Ramuthevar,Vadivel MuruganX
2019-08-20 13:56 ` Andy Shevchenko
2019-08-20 13:59 ` Andy Shevchenko
2019-08-21 5:34 ` Ramuthevar, Vadivel MuruganX [this message]
2019-08-21 5:33 ` Ramuthevar, Vadivel MuruganX
2019-08-20 15:54 ` [PATCH v2 1/2] dt-bindings: phy: intel-emmc-phy: Add YAML schema for LGM " Rob Herring
2019-08-21 5:26 ` Ramuthevar, Vadivel MuruganX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9a793ae-e66c-a6ae-ab05-d253b8eb27d7@linux.intel.com \
--to=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.harliman.liem@intel.com \
--cc=qi-ming.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).