* [PATCH] platform/x86: acer-wmi: Silence "unsupported" message a bit
@ 2018-08-15 23:27 Benjamin Herrenschmidt
2018-08-17 11:07 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2018-08-15 23:27 UTC (permalink / raw)
To: Lee, Chun-Yi; +Cc: Darren Hart, platform-driver-x86, linux-kernel
This driver prints that "Unsupported machine..." message on every boot on
ThinkPad X1 Carbon laptops (and I assume a number of other systems), which
causes graphical boots to "glitch" a bit and is rather annoying ...
Make it a pr_debug instead.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 8952173dd380..7f7192e8fdab 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -2216,7 +2216,7 @@ static int __init acer_wmi_init(void)
if (wmi_has_guid(AMW0_GUID1) &&
!dmi_check_system(amw0_whitelist) &&
quirks == &quirk_unknown) {
- pr_err("Unsupported machine has AMW0_GUID1, unable to load\n");
+ pr_debug("Unsupported machine has AMW0_GUID1, unable to load\n");
return -ENODEV;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] platform/x86: acer-wmi: Silence "unsupported" message a bit
2018-08-15 23:27 [PATCH] platform/x86: acer-wmi: Silence "unsupported" message a bit Benjamin Herrenschmidt
@ 2018-08-17 11:07 ` Andy Shevchenko
2018-08-17 11:09 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2018-08-17 11:07 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Lee, Chun-Yi, Darren Hart, Platform Driver, linux-kernel
On Thu, Aug 16, 2018 at 2:27 AM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> This driver prints that "Unsupported machine..." message on every boot on
> ThinkPad X1 Carbon laptops (and I assume a number of other systems), which
> causes graphical boots to "glitch" a bit and is rather annoying ...
>
> Make it a pr_debug instead.
Thanks for the patch. Unfortunately it doesn't apply.
Please, check your mail clients and tools for formatting patch (it
produced at the end spaces instead of tabs)
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 8952173dd380..7f7192e8fdab 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -2216,7 +2216,7 @@ static int __init acer_wmi_init(void)
> if (wmi_has_guid(AMW0_GUID1) &&
> !dmi_check_system(amw0_whitelist) &&
> quirks == &quirk_unknown) {
> - pr_err("Unsupported machine has AMW0_GUID1, unable to load\n");
> + pr_debug("Unsupported machine has AMW0_GUID1, unable to load\n");
> return -ENODEV;
> }
>
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] platform/x86: acer-wmi: Silence "unsupported" message a bit
2018-08-17 11:07 ` Andy Shevchenko
@ 2018-08-17 11:09 ` Andy Shevchenko
2018-08-17 11:22 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2018-08-17 11:09 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Lee, Chun-Yi, Darren Hart, Platform Driver, linux-kernel
On Fri, Aug 17, 2018 at 2:07 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Thu, Aug 16, 2018 at 2:27 AM, Benjamin Herrenschmidt
> <benh@kernel.crashing.org> wrote:
>> This driver prints that "Unsupported machine..." message on every boot on
>> ThinkPad X1 Carbon laptops (and I assume a number of other systems), which
>> causes graphical boots to "glitch" a bit and is rather annoying ...
>>
>> Make it a pr_debug instead.
>
> Thanks for the patch. Unfortunately it doesn't apply.
> Please, check your mail clients and tools for formatting patch (it
> produced at the end spaces instead of tabs)
No need to resend _this_ time. I have pushed to my review and testing queue.
>>
>> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> ---
>>
>> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>> index 8952173dd380..7f7192e8fdab 100644
>> --- a/drivers/platform/x86/acer-wmi.c
>> +++ b/drivers/platform/x86/acer-wmi.c
>> @@ -2216,7 +2216,7 @@ static int __init acer_wmi_init(void)
>> if (wmi_has_guid(AMW0_GUID1) &&
>> !dmi_check_system(amw0_whitelist) &&
>> quirks == &quirk_unknown) {
>> - pr_err("Unsupported machine has AMW0_GUID1, unable to load\n");
>> + pr_debug("Unsupported machine has AMW0_GUID1, unable to load\n");
>> return -ENODEV;
>> }
>>
>>
>
>
>
> --
> With Best Regards,
> Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] platform/x86: acer-wmi: Silence "unsupported" message a bit
2018-08-17 11:09 ` Andy Shevchenko
@ 2018-08-17 11:22 ` Benjamin Herrenschmidt
2018-08-17 11:27 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2018-08-17 11:22 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Lee, Chun-Yi, Darren Hart, Platform Driver, linux-kernel
On Fri, 2018-08-17 at 14:09 +0300, Andy Shevchenko wrote:
> On Fri, Aug 17, 2018 at 2:07 PM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Thu, Aug 16, 2018 at 2:27 AM, Benjamin Herrenschmidt
> > <benh@kernel.crashing.org> wrote:
> > > This driver prints that "Unsupported machine..." message on every boot on
> > > ThinkPad X1 Carbon laptops (and I assume a number of other systems), which
> > > causes graphical boots to "glitch" a bit and is rather annoying ...
> > >
> > > Make it a pr_debug instead.
> >
> > Thanks for the patch. Unfortunately it doesn't apply.
> > Please, check your mail clients and tools for formatting patch (it
> > produced at the end spaces instead of tabs)
>
> No need to resend _this_ time. I have pushed to my review and testing queue.
Thanks, odd. Not sure what's going on with the latest evolution, it's
the second time it's done this. I'll try to investigate. Small patch
like that I tend to just copy/paste in an email in "preformat" style
;-)
Cheers,
Ben.
>
> > >
> > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > ---
> > >
> > > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> > > index 8952173dd380..7f7192e8fdab 100644
> > > --- a/drivers/platform/x86/acer-wmi.c
> > > +++ b/drivers/platform/x86/acer-wmi.c
> > > @@ -2216,7 +2216,7 @@ static int __init acer_wmi_init(void)
> > > if (wmi_has_guid(AMW0_GUID1) &&
> > > !dmi_check_system(amw0_whitelist) &&
> > > quirks == &quirk_unknown) {
> > > - pr_err("Unsupported machine has AMW0_GUID1, unable to load\n");
> > > + pr_debug("Unsupported machine has AMW0_GUID1, unable to load\n");
> > > return -ENODEV;
> > > }
> > >
> > >
> >
> >
> >
> > --
> > With Best Regards,
> > Andy Shevchenko
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] platform/x86: acer-wmi: Silence "unsupported" message a bit
2018-08-17 11:22 ` Benjamin Herrenschmidt
@ 2018-08-17 11:27 ` Andy Shevchenko
2018-08-17 11:30 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2018-08-17 11:27 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Lee, Chun-Yi, Darren Hart, Platform Driver, linux-kernel
On Fri, Aug 17, 2018 at 2:22 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Fri, 2018-08-17 at 14:09 +0300, Andy Shevchenko wrote:
>> On Fri, Aug 17, 2018 at 2:07 PM, Andy Shevchenko
>> <andy.shevchenko@gmail.com> wrote:
>> > On Thu, Aug 16, 2018 at 2:27 AM, Benjamin Herrenschmidt
>> > <benh@kernel.crashing.org> wrote:
>> > > This driver prints that "Unsupported machine..." message on every boot on
>> > > ThinkPad X1 Carbon laptops (and I assume a number of other systems), which
>> > > causes graphical boots to "glitch" a bit and is rather annoying ...
>> > >
>> > > Make it a pr_debug instead.
>> >
>> > Thanks for the patch. Unfortunately it doesn't apply.
>> > Please, check your mail clients and tools for formatting patch (it
>> > produced at the end spaces instead of tabs)
>>
>> No need to resend _this_ time. I have pushed to my review and testing queue.
>
> Thanks, odd. Not sure what's going on with the latest evolution, it's
> the second time it's done this. I'll try to investigate. Small patch
> like that I tend to just copy/paste in an email in "preformat" style
> ;-)
Evolution is totally broken for years already (yes, I'm still using it
due to Outlook Web Services support, but it's utter PITA).
I could just easily come up with couple of dozens of bugs that are
present there for more than 3 years.
>
> Cheers,
> Ben.
>>
>> > >
>> > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> > > ---
>> > >
>> > > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>> > > index 8952173dd380..7f7192e8fdab 100644
>> > > --- a/drivers/platform/x86/acer-wmi.c
>> > > +++ b/drivers/platform/x86/acer-wmi.c
>> > > @@ -2216,7 +2216,7 @@ static int __init acer_wmi_init(void)
>> > > if (wmi_has_guid(AMW0_GUID1) &&
>> > > !dmi_check_system(amw0_whitelist) &&
>> > > quirks == &quirk_unknown) {
>> > > - pr_err("Unsupported machine has AMW0_GUID1, unable to load\n");
>> > > + pr_debug("Unsupported machine has AMW0_GUID1, unable to load\n");
>> > > return -ENODEV;
>> > > }
>> > >
>> > >
>> >
>> >
>> >
>> > --
>> > With Best Regards,
>> > Andy Shevchenko
>>
>>
>>
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] platform/x86: acer-wmi: Silence "unsupported" message a bit
2018-08-17 11:27 ` Andy Shevchenko
@ 2018-08-17 11:30 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2018-08-17 11:30 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Lee, Chun-Yi, Darren Hart, Platform Driver, linux-kernel
On Fri, 2018-08-17 at 14:27 +0300, Andy Shevchenko wrote:
> On Fri, Aug 17, 2018 at 2:22 PM, Benjamin Herrenschmidt
> <benh@kernel.crashing.org> wrote:
> > On Fri, 2018-08-17 at 14:09 +0300, Andy Shevchenko wrote:
> > > On Fri, Aug 17, 2018 at 2:07 PM, Andy Shevchenko
> > > <andy.shevchenko@gmail.com> wrote:
> > > > On Thu, Aug 16, 2018 at 2:27 AM, Benjamin Herrenschmidt
> > > > <benh@kernel.crashing.org> wrote:
> > > > > This driver prints that "Unsupported machine..." message on every boot on
> > > > > ThinkPad X1 Carbon laptops (and I assume a number of other systems), which
> > > > > causes graphical boots to "glitch" a bit and is rather annoying ...
> > > > >
> > > > > Make it a pr_debug instead.
> > > >
> > > > Thanks for the patch. Unfortunately it doesn't apply.
> > > > Please, check your mail clients and tools for formatting patch (it
> > > > produced at the end spaces instead of tabs)
> > >
> > > No need to resend _this_ time. I have pushed to my review and testing queue.
> >
> > Thanks, odd. Not sure what's going on with the latest evolution, it's
> > the second time it's done this. I'll try to investigate. Small patch
> > like that I tend to just copy/paste in an email in "preformat" style
> > ;-)
>
> Evolution is totally broken for years already (yes, I'm still using it
> due to Outlook Web Services support, but it's utter PITA).
> I could just easily come up with couple of dozens of bugs that are
> present there for more than 3 years.
I had reasonably good luck getting bugs fixed by reporting them via
Fedora actually. But yeah, something with the composer tends to break
regularly.
Cheers,
Ben.
> >
> > Cheers,
> > Ben.
> > >
> > > > >
> > > > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > > > ---
> > > > >
> > > > > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> > > > > index 8952173dd380..7f7192e8fdab 100644
> > > > > --- a/drivers/platform/x86/acer-wmi.c
> > > > > +++ b/drivers/platform/x86/acer-wmi.c
> > > > > @@ -2216,7 +2216,7 @@ static int __init acer_wmi_init(void)
> > > > > if (wmi_has_guid(AMW0_GUID1) &&
> > > > > !dmi_check_system(amw0_whitelist) &&
> > > > > quirks == &quirk_unknown) {
> > > > > - pr_err("Unsupported machine has AMW0_GUID1, unable to load\n");
> > > > > + pr_debug("Unsupported machine has AMW0_GUID1, unable to load\n");
> > > > > return -ENODEV;
> > > > > }
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > With Best Regards,
> > > > Andy Shevchenko
> > >
> > >
> > >
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-08-17 12:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-15 23:27 [PATCH] platform/x86: acer-wmi: Silence "unsupported" message a bit Benjamin Herrenschmidt
2018-08-17 11:07 ` Andy Shevchenko
2018-08-17 11:09 ` Andy Shevchenko
2018-08-17 11:22 ` Benjamin Herrenschmidt
2018-08-17 11:27 ` Andy Shevchenko
2018-08-17 11:30 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).