From: Dou Liyang <douly.fnst@cn.fujitsu.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
<mingo@kernel.org>, <hpa@zytor.com>, <ebiederm@xmission.com>,
<bhe@redhat.com>, <izumi.taku@jp.fujitsu.com>
Subject: Re: [RFC PATCH v3 00/12] Unify interrupt mode and setup it as soon as possible
Date: Tue, 6 Jun 2017 14:50:19 +0800 [thread overview]
Message-ID: <d9d8e6e3-bc5a-a27b-0aa9-92f64f636d9a@cn.fujitsu.com> (raw)
In-Reply-To: <d5e70d4b-9323-7169-4702-dd4f00427b6c@cn.fujitsu.com>
Hi Thomas,
At 05/23/2017 09:29 AM, Dou Liyang wrote:
> Dear Thomas,
>
> At 05/23/2017 04:23 AM, Thomas Gleixner wrote:
>> Dou,
>>
>> On Wed, 10 May 2017, Dou Liyang wrote:
>>
>>> According to Ingo's and Eric's advice[1,2], Try my best to optimize the
>>> init of interrupt delivery mode for x86.
>>
>> sorry for replying late. The patchset is not forgotten, it's on my todo
>> list and I'll tend to it latest next week.
>>
>
> I am very glad to hear that. :)
>
> I will check it again and wait for your advice.
I have come to a code bottleneck. Hope to spend your precious time and
let me move on.
Following is some test results for that patchset.
In a theoretical code analysis, the patchset can wrap the original
logic.
1) The original logic of the interrupt delivery mode setup:
-Step O_1) Keep in PIC mode or virtual wire mode:
Check (smp_found_config || !boot_cpu_has(X86_FEATURE_APIC))
true: PIC mode
false: virtual wire mode
-Step O_2) Try to switch to symmetric IO mode:
O_2_1) In up system:
-Check disable_apic
ture: *O_S_1* (original situation 1)
-Check whether there is a separate or integrated chip
don't has: *O_S_2*
-Check !smp_found_config
ture: *O_S_3*
-Others:
*O_S_4*
O_2_2) In smp-capable system:
-Check !smp_found_config && !acpi_lapic
true: goto *O_2_1)*
-Check if it is LAPIC
don't has: *O_S_5*
-Check !max_cpus
true: *O_S_6*
-read_apic_id() != boot_cpu_physical_apicid
true: *O_S_7*
-Others:
*O_S_8*
2) After that patchset, the new logic:
-Step N_1) Skip step O_1 and try to switch to the final interrupt mode
-Check disable_apic
ture: *N_S_1* (New situation 1)
-Check whether there is a separate or integrated chip
ture: *N_S_2*
-Check if (!smp_found_config)
ture: *N_S_3*
-Check !setup_max_cpus
ture: *N_S_4*
-Check read_apic_id() != boot_cpu_physical_apicid
ture: *N_S_5*
-Others:
*N_S_6*
O_S_1 is covered in N_S_1
O_S_2 is covered in N_S_2
O_S_3 is covered in N_S_3
O_S_4 is covered in N_S_6
O_S_5 is covered in N_S_2
O_S_6 is covered in N_S_4
O_S_7 is covered in N_S_5
O_S_8 is covered in N_S_6
--------------------------------------------
In the actual test, It also can work well in the situations of my test
matrix
The factors of test matrix:
X86 | SMP |LOCAL APIC|I/O APIC|UP_LATE_INIT|
----- |-----|----------|--------|------------|
32-bit| Y | Y | Y | Y |
64-bit| N | N | N | N |
disable_apic|X86_FEATURE_APIC|smp_found_config|
------------|----------------|----------------|
0 | 0 | 0 |
1 | 1 | 1 |
acpi_lapic|acpi_ioapic|setup_max_cpus|
----------|-----------|--------------|
0 | 0 | =0 |
1 | 1 | >0 |
>
> Thanks,
> Liyang.
>
>> Thanks,
>>
>> tglx
>>
>>
>>
next prev parent reply other threads:[~2017-06-06 6:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 13:44 [RFC PATCH v3 00/12] Unify interrupt mode and setup it as soon as possible Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 01/12] x86/apic: Replace init_bsp_APIC() with apic_virtual_wire_mode_setup() Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 02/12] x86/apic: Construct a selector for the interrupt delivery mode Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 03/12] x86/apic: Prepare for unifying the interrupt delivery modes setup Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 04/12] x86/time: Initialize interrupt mode behind timer init Dou Liyang
2017-06-06 6:00 ` [RFC PATCH v4 " Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 05/12] x86/ioapic: Refactor the delay logic in timer_irq_works() Dou Liyang
2017-05-26 8:10 ` [RFC PATCH v4 " Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 06/12] x86/apic: Split local APIC timer setup from the APIC setup Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 07/12] x86/apic: Move the logical APIC ID setup from apic_bsp_setup() Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 08/12] x86/apic: Make interrupt mode setup earlier for SMP-capable system Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 09/12] x86/apic: Setup interrupt mode earlier in case of no SMP motherboard Dou Liyang
2017-05-12 9:55 ` [RFC PATCH v4 " Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 10/12] x86/apic: Make the interrupt mode setup earlier for UP system Dou Liyang
2017-05-11 10:57 ` [RFC PATCH v4 " Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 11/12] x86/apic: Mark the apic_interrupt_mode extern for disable_smp() Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 12/12] x86/apic: Remove the apic_virtual_wire_mode_setup() Dou Liyang
2017-05-22 20:23 ` [RFC PATCH v3 00/12] Unify interrupt mode and setup it as soon as possible Thomas Gleixner
2017-05-23 1:29 ` Dou Liyang
2017-06-06 6:50 ` Dou Liyang [this message]
2017-06-26 10:08 ` Dou Liyang
2017-06-26 11:50 ` Thomas Gleixner
2017-06-27 1:50 ` Dou Liyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9d8e6e3-bc5a-a27b-0aa9-92f64f636d9a@cn.fujitsu.com \
--to=douly.fnst@cn.fujitsu.com \
--cc=bhe@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).