From: David Hildenbrand <david@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Dan Williams <dan.j.williams@intel.com>,
Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH v1] drivers/base/memory.c: Don't store end_section_nr in memory blocks
Date: Wed, 31 Jul 2019 16:43:58 +0200 [thread overview]
Message-ID: <d9db33a5-ca83-13bd-5fcb-5f7d5b3c1bfb@redhat.com> (raw)
In-Reply-To: <20190731143714.GX9330@dhcp22.suse.cz>
On 31.07.19 16:37, Michal Hocko wrote:
> On Wed 31-07-19 16:21:46, David Hildenbrand wrote:
> [...]
>>> Thinking about it some more, I believe that we can reasonably provide
>>> both APIs controlable by a command line parameter for backwards
>>> compatibility. It is the hotplug code to control sysfs APIs. E.g.
>>> create one sysfs entry per add_memory_resource for the new semantic.
>>
>> Yeah, but the real question is: who needs it. I can only think about
>> some DIMM scenarios (some, not all). I would be interested in more use
>> cases. Of course, to provide and maintain two APIs we need a good reason.
>
> Well, my 3TB machine that has 7 movable nodes could really go with less
> than
> $ find /sys/devices/system/memory -name "memory*" | wc -l
> 1729>
The question is if it would be sufficient to increase the memory block
size even further for these kinds of systems (e.g., via a boot parameter
- I think we have that on uv systems) instead of having blocks of
different sizes. Say, 128GB blocks because you're not going to hotplug
128MB DIMMs into such a system - at least that's my guess ;)
> when it doesn't really make any sense to offline less than a
> hotremovable entity which is the whole node effectivelly. I have seen
> reports where a similarly large machine chocked on boot just because of
> too many udev events...>
> In other words allowing smaller granularity is a nice toy but real
> usecases usually work with the whole hotplugable entity (e.g. the whole
> ACPI container).
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-07-31 14:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 12:22 [PATCH v1] drivers/base/memory.c: Don't store end_section_nr in memory blocks David Hildenbrand
2019-07-31 12:43 ` Michal Hocko
2019-07-31 13:12 ` David Hildenbrand
2019-07-31 13:25 ` Michal Hocko
2019-07-31 13:42 ` David Hildenbrand
2019-07-31 14:04 ` David Hildenbrand
2019-07-31 14:15 ` Michal Hocko
2019-07-31 14:23 ` David Hildenbrand
2019-07-31 14:14 ` Michal Hocko
2019-07-31 14:21 ` David Hildenbrand
2019-07-31 14:37 ` Michal Hocko
2019-07-31 14:43 ` David Hildenbrand [this message]
2019-08-01 6:13 ` Michal Hocko
2019-08-01 7:00 ` David Hildenbrand
2019-08-01 8:27 ` Michal Hocko
2019-08-01 8:36 ` David Hildenbrand
2019-07-31 20:57 ` Andrew Morton
2019-08-01 6:48 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9db33a5-ca83-13bd-5fcb-5f7d5b3c1bfb@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).