* [PATCH] keys: remove trailing semicolon in macro definition
@ 2020-11-27 19:15 trix
2020-11-29 4:45 ` Jarkko Sakkinen
2020-11-30 8:58 ` David Howells
0 siblings, 2 replies; 5+ messages in thread
From: trix @ 2020-11-27 19:15 UTC (permalink / raw)
To: dhowells, jarkko; +Cc: keyrings, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
The macro use will already have a semicolon.
Signed-off-by: Tom Rix <trix@redhat.com>
---
include/linux/key.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/key.h b/include/linux/key.h
index 0f2e24f13c2b..1b0837c975b9 100644
--- a/include/linux/key.h
+++ b/include/linux/key.h
@@ -360,7 +360,7 @@ static inline struct key *request_key(struct key_type *type,
* completion of keys undergoing construction with a non-interruptible wait.
*/
#define request_key_net(type, description, net, callout_info) \
- request_key_tag(type, description, net->key_domain, callout_info);
+ request_key_tag(type, description, net->key_domain, callout_info)
/**
* request_key_net_rcu - Request a key for a net namespace under RCU conditions
@@ -372,7 +372,7 @@ static inline struct key *request_key(struct key_type *type,
* network namespace are used.
*/
#define request_key_net_rcu(type, description, net) \
- request_key_rcu(type, description, net->key_domain);
+ request_key_rcu(type, description, net->key_domain)
#endif /* CONFIG_NET */
extern int wait_for_key_construction(struct key *key, bool intr);
--
2.18.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] keys: remove trailing semicolon in macro definition
2020-11-27 19:15 [PATCH] keys: remove trailing semicolon in macro definition trix
@ 2020-11-29 4:45 ` Jarkko Sakkinen
2020-11-29 5:30 ` Joe Perches
2020-11-30 8:58 ` David Howells
1 sibling, 1 reply; 5+ messages in thread
From: Jarkko Sakkinen @ 2020-11-29 4:45 UTC (permalink / raw)
To: trix; +Cc: dhowells, keyrings, linux-kernel
On Fri, Nov 27, 2020 at 11:15:43AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
I'm in-between whether this is worth of merging. The commit message
does not help with that decision too much.
/Jarkko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] keys: remove trailing semicolon in macro definition
2020-11-29 4:45 ` Jarkko Sakkinen
@ 2020-11-29 5:30 ` Joe Perches
2020-12-02 16:45 ` Jarkko Sakkinen
0 siblings, 1 reply; 5+ messages in thread
From: Joe Perches @ 2020-11-29 5:30 UTC (permalink / raw)
To: Jarkko Sakkinen, trix; +Cc: dhowells, keyrings, linux-kernel
On Sun, 2020-11-29 at 06:45 +0200, Jarkko Sakkinen wrote:
> On Fri, Nov 27, 2020 at 11:15:43AM -0800, trix@redhat.com wrote:
> > From: Tom Rix <trix@redhat.com>
> >
> > The macro use will already have a semicolon.
> >
> > Signed-off-by: Tom Rix <trix@redhat.com>
>
> I'm in-between whether this is worth of merging. The commit message
> does not help with that decision too much.
It seems worthy of merging to me modulo whatver improvement is desired in
the commit message.
There are 3 existing uses of request_key_net. All have a trailing semicolon.
There is 1 existing use of request_key_net_rcu. It has a trailing semicolon.
No object change should occur.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] keys: remove trailing semicolon in macro definition
2020-11-27 19:15 [PATCH] keys: remove trailing semicolon in macro definition trix
2020-11-29 4:45 ` Jarkko Sakkinen
@ 2020-11-30 8:58 ` David Howells
1 sibling, 0 replies; 5+ messages in thread
From: David Howells @ 2020-11-30 8:58 UTC (permalink / raw)
To: Jarkko Sakkinen; +Cc: dhowells, trix, keyrings, linux-kernel
Jarkko Sakkinen <jarkko@kernel.org> wrote:
> I'm in-between whether this is worth of merging. The commit message
> does not help with that decision too much.
It is worth merging. It might cause problems for someone using it in the body
of an if-statement, say, if they don't put braces in, but do put a semicolon
on the end. I'll add it to my branch.
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] keys: remove trailing semicolon in macro definition
2020-11-29 5:30 ` Joe Perches
@ 2020-12-02 16:45 ` Jarkko Sakkinen
0 siblings, 0 replies; 5+ messages in thread
From: Jarkko Sakkinen @ 2020-12-02 16:45 UTC (permalink / raw)
To: Joe Perches; +Cc: trix, dhowells, keyrings, linux-kernel
On Sat, Nov 28, 2020 at 09:30:44PM -0800, Joe Perches wrote:
> On Sun, 2020-11-29 at 06:45 +0200, Jarkko Sakkinen wrote:
> > On Fri, Nov 27, 2020 at 11:15:43AM -0800, trix@redhat.com wrote:
> > > From: Tom Rix <trix@redhat.com>
> > >
> > > The macro use will already have a semicolon.
> > >
> > > Signed-off-by: Tom Rix <trix@redhat.com>
> >
> > I'm in-between whether this is worth of merging. The commit message
> > does not help with that decision too much.
>
> It seems worthy of merging to me modulo whatver improvement is desired in
> the commit message.
>
> There are 3 existing uses of request_key_net. All have a trailing semicolon.
> There is 1 existing use of request_key_net_rcu. It has a trailing semicolon.
>
> No object change should occur.
OK, makes sense.
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
/Jarkko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-02 16:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 19:15 [PATCH] keys: remove trailing semicolon in macro definition trix
2020-11-29 4:45 ` Jarkko Sakkinen
2020-11-29 5:30 ` Joe Perches
2020-12-02 16:45 ` Jarkko Sakkinen
2020-11-30 8:58 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).