linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Liu Song <liusong@linux.alibaba.com>
To: David Hildenbrand <david@redhat.com>,
	Yuanhe Shu <xiangzao@linux.alibaba.com>,
	akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm, thp: display [never] for defrag when THP is set to never
Date: Fri, 23 Feb 2024 19:01:58 +0800	[thread overview]
Message-ID: <d9eb6672-788e-414d-8138-37a3038e3c47@linux.alibaba.com> (raw)
In-Reply-To: <ec6f2c48-3010-4a02-8f42-fc6b912039cf@redhat.com>


在 2024/2/22 20:14, David Hildenbrand 写道:
> On 22.02.24 12:53, Yuanhe Shu wrote:
>> When transparent_hugepage is set to never by cmdline or echo, defrag
>> still show what it used to be and can be modified which makes user
>> confusing whether defrag would take effect.
>>
>> Actually if transparent_hugepage is set to never, defrag will not take
>> effect. Just Display never and remain unchangeable to for defrag when
>> transparent_hugepage is set to never.
>>
>> Suggested-by: Liu Song <liusong@linux.alibaba.com>
>> Signed-off-by: Yuanhe Shu <xiangzao@linux.alibaba.com>
>> ---
>
> No, I don't think we want such a dependency between both options.
>
> You might just end up breaking existing scripts (enable defrag before 
> enabling THP) for no good reason.
>
In certain situations where khugepaged_thread is NULL, it would be more
reasonable for the value of
/sys/kernel/mm/transparent_hugepage/khugepaged/defrag to be 0. The patch
should include a fix for this case.

Thanks




  reply	other threads:[~2024-02-23 11:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22 11:53 [PATCH] mm, thp: display [never] for defrag when THP is set to never Yuanhe Shu
2024-02-22 12:14 ` David Hildenbrand
2024-02-23 11:01   ` Liu Song [this message]
2024-02-26  8:54     ` David Hildenbrand
2024-02-26 11:22       ` Liu Song
2024-02-26 11:48         ` David Hildenbrand
2024-02-26 11:49           ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9eb6672-788e-414d-8138-37a3038e3c47@linux.alibaba.com \
    --to=liusong@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=xiangzao@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).