From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Pavel Machek <pavel@denx.de>, Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, Dave Gerlach <d-gerlach@ti.com>,
Faiz Abbas <faiz_abbas@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Keerthy <j-keerthy@ti.com>, Nishanth Menon <nm@ti.com>,
Suman Anna <s-anna@ti.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] bus: ti-sysc: Fix error handling for sysc_check_active_timer()
Date: Sun, 15 Aug 2021 21:05:04 +0300 [thread overview]
Message-ID: <d9ebbc7f-07f1-160f-f463-7c54ed8dd6d7@bitmer.com> (raw)
In-Reply-To: <20210811062231.GA16241@duo.ucw.cz>
Hi
On 8/11/21 9:22 AM, Pavel Machek wrote:
> On Wed 2021-08-11 09:10:53, Tony Lindgren wrote:
>> We have changed the return type for sysc_check_active_timer() from -EBUSY
>> to -ENXIO, but the gpt12 system timer fix still checks for -EBUSY. We are
>> also not returning on other errors like we did earlier as noted by
>> Pavel Machek <pavel@denx.de>.
>>
>> Commit 3ff340e24c9d ("bus: ti-sysc: Fix gpt12 system timer issue with
>> reserved status") should have been updated for commit 65fb73676112
>> ("bus: ti-sysc: suppress err msg for timers used as clockevent/source").
>>
>> Let's fix the issue by checking for -ENXIO and returning on any other
>> errors as suggested by Pavel Machek <pavel@denx.de>.
>>
>> Fixes: 3ff340e24c9d ("bus: ti-sysc: Fix gpt12 system timer issue with reserved status")
>> Depends-on: 65fb73676112 ("bus: ti-sysc: suppress err msg for timers used as clockevent/source")
>> Reported-by: Pavel Machek <pavel@denx.de>
>> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
>> Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
>> Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> Reviewed-by: Pavel Machek (CIP) <pavel@denx.de>
>
I double checked but actually both plain 0aa78d17099b ("Merge tag
'scsi-fixes' of
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi") and with this
patch boot fine on my Beagle C2.
Anyway,
Tested-by: jarkko.nikula@bitmer.com
next prev parent reply other threads:[~2021-08-15 18:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 6:10 [PATCH] bus: ti-sysc: Fix error handling for sysc_check_active_timer() Tony Lindgren
2021-08-11 6:22 ` Pavel Machek
2021-08-15 18:05 ` Jarkko Nikula [this message]
2021-08-19 6:36 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9ebbc7f-07f1-160f-f463-7c54ed8dd6d7@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=d-gerlach@ti.com \
--cc=faiz_abbas@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=pavel@denx.de \
--cc=s-anna@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).