From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752769AbdJaHFd (ORCPT ); Tue, 31 Oct 2017 03:05:33 -0400 Received: from lucky1.263xmail.com ([211.157.147.135]:35900 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbdJaHFb (ORCPT ); Tue, 31 Oct 2017 03:05:31 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Cc: Jaehoon Chung , shawn.lin@rock-chips.com, Ziyuan Xu , Alexandru Stan , "open list:ARM/Rockchip SoC..." , Brian Norris , linux-samsung-soc , kernel@esmil.dk, "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 0/5] mmc: dw_mmc: Fix the CTO timer patch, plus the DTO timer To: Ulf Hansson , Douglas Anderson References: <20171012201118.23570-1-dianders@chromium.org> From: Shawn Lin Message-ID: Date: Tue, 31 Oct 2017 15:05:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ulf, On 2017/10/30 19:40, Ulf Hansson wrote: > On 12 October 2017 at 22:11, Douglas Anderson wrote: >> Recently we landed 03de19212ea3 ("mmc: dw_mmc: introduce timer for >> broken command transfer over scheme"). I found a bunch of problems >> with that patch, so this series attempts to solve some of them. >> >> This also fixes the DTO timer in some of the same ways even though I >> haven't personally seen problems with the DTO timer. >> >> NOTE: this series has only been lighly tested so far. I can at least >> reproduce the need for the CTO timer on one of my devices and so I can >> confirm that part still works. As mentioned in the 3rd patch I also >> ran the mmc_test kernel module on this and did manage to see the 3rd >> patch doing something useful. >> >> Changes in v2: >> - Removed extra "int i" >> - Fix the DTO timeout calculation new for v2 >> - Cleanup the DTO timer new for v2 >> >> Douglas Anderson (5): >> mmc: dw_mmc: cancel the CTO timer after a voltage switch >> mmc: dw_mmc: Fix the CTO timeout calculation >> mmc: dw_mmc: Add locking to the CTO timer >> mmc: dw_mmc: Fix the DTO timeout calculation >> mmc: dw_mmc: Cleanup the DTO timer like the CTO one >> >> drivers/mmc/host/dw_mmc.c | 162 +++++++++++++++++++++++++++++++++++++++++----- >> 1 file changed, 146 insertions(+), 16 deletions(-) >> > > Douglas, Jaehoon, > > I decided to pick patch 1->4 for fixes and the patch 5 for next, that > should help us to get them more tested, while Jaehoon is still > catching up. > > I can add ack/drop patches for yet a couple of days this week. Patch 4 introduce a warning: warning: unused variable ‘irqflags’ [-Wunused-variable] irqflags should be introduced in patch 5 in the same place. As it seems patch 5 will be candidate for 4.15, so could you please help fix patch 4 and 5 manually? Or Doug need to resend patch 4 and 5? > > Kind regards > Uffe > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > >