From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BC1FC3F2D1 for ; Thu, 5 Mar 2020 00:29:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DE5920870 for ; Thu, 5 Mar 2020 00:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583368162; bh=LXMiZGn7WQguRaonRX3+udH76MPkkFFGfMmHgnOHruI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=WyozZunWW8426wcmxIyLWT9yvadZ0j0h+D+yHPYJ0Q8iu5S5p9DRim7Ehi/Yo73ec UKtsfPJD5NALUN8Qrjbr4F6QUZvUT9Rnpw9x9YT9mvzBvklH67BQB4PV4yL4bX7T1R QecYs2qoL+HuT4EkU0Rrr1rAzQgGXUB1sxvhOexE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388615AbgCEA3V (ORCPT ); Wed, 4 Mar 2020 19:29:21 -0500 Received: from mail-il1-f194.google.com ([209.85.166.194]:35994 "EHLO mail-il1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388589AbgCEA3U (ORCPT ); Wed, 4 Mar 2020 19:29:20 -0500 Received: by mail-il1-f194.google.com with SMTP id b17so3505123iln.3 for ; Wed, 04 Mar 2020 16:29:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DMuXBI4n6VFH3vcmCnA8kWV3eDknxjUy9BFc+h/MzKY=; b=BzVBYccsXnBXQL8L4nriLT4wgNKsO/qjfzqlAJN1M5w8pTENcT4OLw0Esd5zBKM4Ws l08LyYnuwPv6FKWz7kZMosKXMI5dnF1gmkRPzi5UCbCLEbsb6s6ThdBHDyArCXk8HVZ7 miNbYmMMN1oklJ9Lg93WhI0agt1FOPlhhvsq0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DMuXBI4n6VFH3vcmCnA8kWV3eDknxjUy9BFc+h/MzKY=; b=Qy85d5nQYu7ZTg1Url8oWLfH6LSTohFtxTFBu+W4CthLuFW+5OhX0xftxI1mG19xtT DULxI1gcDyzxvcYu5uEeyr52/xG2N0dvpDe6Jug6uecACCFk+fjzensKX0+fl26A3QL+ aPycSN9rzXWNnpYAZS9nlE2DtlZy23g6gndiK367sQKOx9rN7xVqP5kiEpQgqMPd0S6g mB8g7unUufN8P9stT6eBOzvFK3qzS2IR0MFilGqQMN8cgEZYUzIO5cBfkHPzvCSwX8ip yun07YfX8GAHlvc4rvYEs9bTM83ikzbVcx2p1VzjSqJiJSkLtweW7111H52MgRPCHpgI hHhA== X-Gm-Message-State: ANhLgQ2trLE90dgesYJmMbJw3XH5OcssxJ0pD9LbzqgNA1SiS/1yU1A+ fWRmNDILkD8LHsGhNOpuYbsVgA== X-Google-Smtp-Source: ADFU+vsj6BlimOUY1cjq4xUk/QovllsyeGkV1HNUuBRFKOYD/q6CBKOvI+ohh2SeR6TANE6+s96y1Q== X-Received: by 2002:a92:914a:: with SMTP id t71mr4854237ild.108.1583368158380; Wed, 04 Mar 2020 16:29:18 -0800 (PST) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id i16sm9674080ils.41.2020.03.04.16.29.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2020 16:29:17 -0800 (PST) Subject: Re: [PATCH 2/4] selftests: Fix seccomp to support relocatable build (O=objdir) To: Michael Ellerman , Kees Cook Cc: shuah@kernel.org, luto@amacapital.net, wad@chromium.org, daniel@iogearbox.net, kafai@fb.com, yhs@fb.com, andriin@fb.com, gregkh@linuxfoundation.org, tglx@linutronix.de, khilman@baylibre.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Shuah Khan References: <11967e5f164f0cd717921bd382ff9c13ef740146.1583358715.git.skhan@linuxfoundation.org> <202003041442.A46000C@keescook> <11ffe43f-f777-7881-623d-c93196a44cb6@linuxfoundation.org> <87eeu7r6qf.fsf@mpe.ellerman.id.au> From: Shuah Khan Message-ID: Date: Wed, 4 Mar 2020 17:29:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87eeu7r6qf.fsf@mpe.ellerman.id.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/4/20 5:22 PM, Michael Ellerman wrote: > Shuah Khan writes: >> On 3/4/20 3:42 PM, Kees Cook wrote: >>> On Wed, Mar 04, 2020 at 03:13:33PM -0700, Shuah Khan wrote: >>>> Fix seccomp relocatable builds. This is a simple fix to use the >>>> right lib.mk variable TEST_GEN_PROGS for objects to leverage >>>> lib.mk common framework for relocatable builds. >>>> >>>> Signed-off-by: Shuah Khan >>>> --- >>>> tools/testing/selftests/seccomp/Makefile | 16 +++------------- >>>> 1 file changed, 3 insertions(+), 13 deletions(-) >>>> >>>> diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile >>>> index 1760b3e39730..a8a9717fc1be 100644 >>>> --- a/tools/testing/selftests/seccomp/Makefile >>>> +++ b/tools/testing/selftests/seccomp/Makefile >>>> @@ -1,17 +1,7 @@ >>>> # SPDX-License-Identifier: GPL-2.0 >>>> -all: >>>> - >>>> -include ../lib.mk >>>> - >>>> -.PHONY: all clean >>>> - >>>> -BINARIES := seccomp_bpf seccomp_benchmark >>>> CFLAGS += -Wl,-no-as-needed -Wall >>>> +LDFLAGS += -lpthread >>>> >>>> -seccomp_bpf: seccomp_bpf.c ../kselftest_harness.h >>> >>> How is the ../kselftest_harness.h dependency detected in the resulting >>> build rules? >>> >>> Otherwise, looks good. >> >> Didn't see any problems. I will look into adding the dependency. > > Before: > > $ make --no-print-directory -C tools/testing/selftests/ TARGETS=seccomp > make --no-builtin-rules INSTALL_HDR_PATH=$BUILD/usr \ > ARCH=powerpc -C ../../.. headers_install > INSTALL /home/michael/build/adhoc/kselftest/usr/include > gcc -Wl,-no-as-needed -Wall seccomp_bpf.c -lpthread -o seccomp_bpf > gcc -Wl,-no-as-needed -Wall seccomp_benchmark.c -o seccomp_benchmark > > $ touch tools/testing/selftests/kselftest_harness.h > > $ make --no-print-directory -C tools/testing/selftests/ TARGETS=seccomp > make --no-builtin-rules INSTALL_HDR_PATH=$BUILD/usr \ > ARCH=powerpc -C ../../.. headers_install > INSTALL /home/michael/build/adhoc/kselftest/usr/include > gcc -Wl,-no-as-needed -Wall seccomp_bpf.c -lpthread -o seccomp_bpf > $ > > Note that touching the header causes it to rebuild seccomp_bpf. > > With this patch applied: > > $ make --no-print-directory -C tools/testing/selftests/ TARGETS=seccomp > make -s --no-builtin-rules INSTALL_HDR_PATH=$BUILD/usr \ > ARCH=powerpc -C ../../.. headers_install > gcc -Wl,-no-as-needed -Wall -lpthread seccomp_bpf.c -o /home/michael/build/adhoc/kselftest/seccomp/seccomp_bpf > gcc -Wl,-no-as-needed -Wall -lpthread seccomp_benchmark.c -o /home/michael/build/adhoc/kselftest/seccomp/seccomp_benchmark > > $ touch tools/testing/selftests/kselftest_harness.h > > $ make --no-print-directory -C tools/testing/selftests/ TARGETS=seccomp > make -s --no-builtin-rules INSTALL_HDR_PATH=$BUILD/usr \ > ARCH=powerpc -C ../../.. headers_install > make[1]: Nothing to be done for 'all'. > $ > > Thanks. I realized I overlooked header dependency case. > So yeah it still needs: > > seccomp_bpf: ../kselftest_harness.h > > Yes v2 coming up. It also has to handle OUTPUT relocation. thanks, -- Shuah