From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: linux-kernel@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
drinkcat@chromium.org, Jitao Shi <jitao.shi@mediatek.com>,
Ulrich Hecht <uli@fpond.eu>, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org, hsinyi@chromium.org,
matthias.bgg@gmail.com,
Collabora Kernel ML <kernel@collabora.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v21 1/2] Documentation: bridge: Add documentation for ps8640 DT properties
Date: Wed, 18 Dec 2019 16:24:21 +0100 [thread overview]
Message-ID: <da1f3c1b-30b5-7708-9527-7f210e817a31@collabora.com> (raw)
In-Reply-To: <20191217142821.xitumpvfg52heb4t@gilmour.lan>
Hi Maxime,
Thanks for your comment, just preparing another version.
On 17/12/19 15:28, Maxime Ripard wrote:
> On Mon, Dec 16, 2019 at 02:58:33PM +0100, Enric Balletbo i Serra wrote:
>> From: Jitao Shi <jitao.shi@mediatek.com>
>>
>> Add documentation for DT properties supported by
>> ps8640 DSI-eDP converter.
>>
>> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
>> Acked-by: Rob Herring <robh@kernel.org>
>> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
>> Signed-off-by: Ulrich Hecht <uli@fpond.eu>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> ---
>>
>> Changes in v21: None
>> Changes in v19: None
>> Changes in v18: None
>> Changes in v17: None
>> Changes in v16: None
>> Changes in v15: None
>> Changes in v14: None
>> Changes in v13: None
>> Changes in v12: None
>> Changes in v11: None
>>
>> .../bindings/display/bridge/ps8640.txt | 44 +++++++++++++++++++
>> 1 file changed, 44 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/display/bridge/ps8640.txt
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/ps8640.txt b/Documentation/devicetree/bindings/display/bridge/ps8640.txt
>> new file mode 100644
>> index 000000000000..7b13f92f7359
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/bridge/ps8640.txt
>> @@ -0,0 +1,44 @@
>> +ps8640-bridge bindings
>> +
>> +Required properties:
>> + - compatible: "parade,ps8640"
>> + - reg: first page address of the bridge.
>> + - sleep-gpios: OF device-tree gpio specification for PD pin.
>> + - reset-gpios: OF device-tree gpio specification for reset pin.
>> + - vdd12-supply: OF device-tree regulator specification for 1.2V power.
>> + - vdd33-supply: OF device-tree regulator specification for 3.3V power.
>> + - ports: The device node can contain video interface port nodes per
>> + the video-interfaces bind[1]. For port@0,set the reg = <0> as
>> + ps8640 dsi in and port@1,set the reg = <1> as ps8640 eDP out.
>> +
>> +Optional properties:
>> + - mode-sel-gpios: OF device-tree gpio specification for mode-sel pin.
>> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
>> +
>> +Example:
>> + edp-bridge@18 {
>> + compatible = "parade,ps8640";
>> + reg = <0x18>;
>> + sleep-gpios = <&pio 116 GPIO_ACTIVE_LOW>;
>> + reset-gpios = <&pio 115 GPIO_ACTIVE_LOW>;
>> + mode-sel-gpios = <&pio 92 GPIO_ACTIVE_HIGH>;
>> + vdd12-supply = <&ps8640_fixed_1v2>;
>> + vdd33-supply = <&mt6397_vgp2_reg>;
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + port@0 {
>> + reg = <0>;
>> + ps8640_in: endpoint {
>> + remote-endpoint = <&dsi0_out>;
>> + };
>> + };
>> + port@1 {
>> + reg = <1>;
>> + ps8640_out: endpoint {
>> + remote-endpoint = <&panel_in>;
>> + };
>> + };
>> + };
>> + };
>
> It's not really fair to ask this after the rough history of this
> patchset apparently, but bindings should be submitted in the YAML
> format now.
>
> This wouldn't be nice to stop it from going in just because of this,
> so can you send a subsequent patch fixing this?
>
I don't mind to use YAML format for next version, in fact, I think is the best.
Thanks,
Enric
> Thanks!
> Maxime
>
next prev parent reply other threads:[~2019-12-18 15:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 13:58 [PATCH v21 0/2] drm/bridge: PS8640 MIPI-to-eDP bridge Enric Balletbo i Serra
2019-12-16 13:58 ` [PATCH v21 1/2] Documentation: bridge: Add documentation for ps8640 DT properties Enric Balletbo i Serra
2019-12-17 14:28 ` Maxime Ripard
2019-12-18 15:24 ` Enric Balletbo i Serra [this message]
2019-12-16 13:58 ` [PATCH v21 2/2] drm/bridge: Add I2C based driver for ps8640 bridge Enric Balletbo i Serra
2019-12-16 16:32 ` Laurent Pinchart
2019-12-18 12:14 ` Enric Balletbo i Serra
2019-12-16 17:07 ` Ezequiel Garcia
2019-12-18 15:21 ` Enric Balletbo i Serra
2019-12-18 17:22 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da1f3c1b-30b5-7708-9527-7f210e817a31@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=hsinyi@chromium.org \
--cc=jitao.shi@mediatek.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=maxime@cerno.tech \
--cc=robh+dt@kernel.org \
--cc=uli@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).