From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: James Bottomley <jejb@linux.ibm.com>,
"Enrico Weigelt, metux IT consult" <info@metux.net>,
linux-kernel@vger.kernel.org
Cc: khalid@gonehiking.org, martin.petersen@oracle.com,
aacraid@microsemi.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2] drivers: scsi: remove unnecessary #ifdef MODULE
Date: Fri, 7 Jun 2019 23:50:55 +0200 [thread overview]
Message-ID: <da4cea67-7651-7284-51e6-5313b1241a8a@metux.net> (raw)
In-Reply-To: <1559868089.3233.1.camel@linux.ibm.com>
On 07.06.19 02:41, James Bottomley wrote:
> On Thu, 2019-06-06 at 17:04 +0200, Enrico Weigelt, metux IT consult
> wrote:
>> From: Enrico Weigelt <info@metux.net>
>>
>> The MODULE_DEVICE_TABLE() macro already checks for MODULE defined,
>> so the extra check here is not necessary.
>>
>> Changes v2:
>> * make dptids const to fix warning on unused variable
>
> I don't think this works; in my version of gcc, const does not defeat
> the unused variable warning if I try with a test programme:
>
> jejb@jarvis:~> gcc -Wunused-variable -c test1.c
> test1.c:3:18: warning: ‘i’ defined but not used [-Wunused-cons
> t-variable=]
> static const int i[] = { 1, 2, 3};
Which gcc version are you using ?
Could you please have a try w/ the kernel (plus my patch) ?
Tested w/ 6.3.0-18+deb9u1 (stretch-amd64), got no warnings.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
prev parent reply other threads:[~2019-06-07 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 15:04 [PATCH v2] drivers: scsi: remove unnecessary #ifdef MODULE Enrico Weigelt, metux IT consult
2019-06-07 0:41 ` James Bottomley
2019-06-07 21:50 ` Enrico Weigelt, metux IT consult [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da4cea67-7651-7284-51e6-5313b1241a8a@metux.net \
--to=lkml@metux.net \
--cc=aacraid@microsemi.com \
--cc=info@metux.net \
--cc=jejb@linux.ibm.com \
--cc=khalid@gonehiking.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).