From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CA09C433E2 for ; Wed, 24 Mar 2021 11:25:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2E1561A15 for ; Wed, 24 Mar 2021 11:25:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234750AbhCXLZD (ORCPT ); Wed, 24 Mar 2021 07:25:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:57494 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232820AbhCXLYn (ORCPT ); Wed, 24 Mar 2021 07:24:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616585083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lh92eKH08v+5P713WfsuE7oYAeLerhzo8+IyAgchy40=; b=JE24VgcWr+Gocs0ukC7SGnMkxlb05HIFdwmjcrQFS979/Yltz7q09PouG2Cu8cs95DyTH/ Igemqf6LpmRqe3CWtL75gos207i1W3NSkTPuRBhl2TvwZisykwnTlilTXHRMHwqUkhxxFB 1loc9shbvR4LmJpNs8HBuN8KsFzWqlM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-496-ny7gnOmXOuaQQ8MTbH-zvQ-1; Wed, 24 Mar 2021 07:24:41 -0400 X-MC-Unique: ny7gnOmXOuaQQ8MTbH-zvQ-1 Received: by mail-wm1-f71.google.com with SMTP id l16so518690wmc.0 for ; Wed, 24 Mar 2021 04:24:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Lh92eKH08v+5P713WfsuE7oYAeLerhzo8+IyAgchy40=; b=WejvctU9RrJyPOJfC3wg58BhKSW25heAkDbA69m4tn2tQwxMMz0RU94k9XPfOYIet3 FpI2QRJgke2lLczqg/2ijVvyXQ89ibX3/stwdEVbPMXapee8obn3L41KxT8tS3pMHM4v 9LnCYAYWzV4O4u+WP1erZPNnbaP0RqH8Fev5wTs/Nzj4LRSGOKa61xqdT+ZZwhTAugah NqBtttTvWJTCSm/p8xVX/51rdavD959A3bJyVU8r7HPtBW6kRnEVLOD0fOq5HPA9QTXJ giuGmMD7xetiYtighHwEnWS+veUH69q4IzfSk4GIn1Kv82RBTqWSUcZuxLCQeyNGjK9i PtBw== X-Gm-Message-State: AOAM533I49i1n4SYU6PF4ftPTEW2dgbXX7+xjfb/v2oz2NxUN6y2x3wk KfNSv9mm9ZZ14paS8BPh1xAQE0GGenv5ENKvz7FJnC5yIQKQaglqGagjfUREKkTQBq6L5lWEtBd 9sIQ323CyBxiO6Cp6/7RTYdb2 X-Received: by 2002:a5d:47c4:: with SMTP id o4mr2910661wrc.138.1616585080073; Wed, 24 Mar 2021 04:24:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzISiGwzhOJ3OFW1AOV7TUCEjxSzOLMAw0VEpovQznGB5jkO7qA6BNwL6xgIZ4D1NB0cUGCFQ== X-Received: by 2002:a5d:47c4:: with SMTP id o4mr2910626wrc.138.1616585079801; Wed, 24 Mar 2021 04:24:39 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id s9sm2306712wmh.31.2021.03.24.04.24.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 04:24:38 -0700 (PDT) Subject: Re: [PATCH v3 03/25] x86/sgx: Wipe out EREMOVE from sgx_free_epc_page() To: Kai Huang Cc: Borislav Petkov , Sean Christopherson , kvm@vger.kernel.org, x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, jarkko@kernel.org, luto@kernel.org, dave.hansen@intel.com, rick.p.edgecombe@intel.com, haitao.huang@intel.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com References: <20210322191540.GH6481@zn.tnic> <20210322210645.GI6481@zn.tnic> <20210323110643.f29e214ebe8ec7a4a3d0bc2e@intel.com> <20210322223726.GJ6481@zn.tnic> <20210323121643.e06403a1bc7819bab7c15d95@intel.com> <20210323160604.GB4729@zn.tnic> <20210323163258.GC4729@zn.tnic> <236c0aa9-92f2-97c8-ab11-d55b9a98c931@redhat.com> <20210324234839.bf5bef54fd7a84030cf1bcf8@intel.com> From: Paolo Bonzini Message-ID: Date: Wed, 24 Mar 2021 12:24:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210324234839.bf5bef54fd7a84030cf1bcf8@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/03/21 11:48, Kai Huang wrote: >>> +/* Error message for EREMOVE failure, when kernel is about to leak EPC page */ >>> +#define EREMOVE_ERROR_MESSAGE \ >>> + "EREMOVE returned %d (0x%x), kernel bug likely. EPC page leaked, SGX may become >>> unusuable. Please refer to Documentation/x86/sgx.rst for more information." >> Rewritten: >> >> EREMOVE returned %d and an EPC page was leaked; SGX may become unusable. >> This is a kernel bug, refer to Documentation/x86/sgx.rst for more information. > Fine to me, although this would have %d (0x%x) -> %d change in the code. > Yeah you can of course keep the 0x%x part. Paolo