LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
	Marek Belisko <marek.belisko@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Deepa Dinamani <deepa.kernel@gmail.com>
Subject: Re: Bad MAINTAINERS pattern in section 'STAGING - FLARION FT1000 DRIVERS'
Date: Fri, 28 Sep 2018 18:15:42 -0700
Message-ID: <da894e81adc28ac98d9c399d24d8eb075b30fd1a.camel@perches.com> (raw)
In-Reply-To: <20180929004649.GA28840@kroah.com>


[-- Attachment #1: Type: text/plain, Size: 2592 bytes --]

On Fri, 2018-09-28 at 17:46 -0700, Greg Kroah-Hartman wrote:
> On Fri, Sep 28, 2018 at 03:04:23PM -0700, Joe Perches wrote:
> > Please fix this defect appropriately.
> > 
> > linux-next MAINTAINERS section:
> > 
> > 	13899	STAGING - FLARION FT1000 DRIVERS
> > 	13900	M:	Marek Belisko <marek.belisko@gmail.com>
> > 	13901	S:	Odd Fixes
> > -->	13902	F:	drivers/staging/ft1000/
> > 
> > Commit that introduced this:
> > 
> > commit a0138163cfbfdfbdc20e4477c77bd7046bd66bb4
> >  Author: Joe Perches <joe@perches.com>
> >  Date:   Tue Jul 5 15:21:34 2011 -0700
> >  
> >      MAINTAINERS: Add remaining staging entries
> >      
> >      Add the staging entries from various TODO files
> >      to MAINTAINERS.  Add a few web links as well.
> >      
> >      Miscellaneous staging typo section header fix.
> >      
> >      Signed-off-by: Joe Perches <joe@perches.com>
> >      Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> >  
> >   MAINTAINERS | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> >   1 file changed, 68 insertions(+), 1 deletion(-)
> 
> So you are going to fix this, considering you created the problem?

_I_ did not create this problem.

You neglected to read the commit information below this in the
parent email.

When I wrote the MAINTAINERS patch in 2011, the files existed.

The files were removed in 2015 and you signed-off on their removal.

----------------------------------------------
Last commit with drivers/staging/ft1000/

commit 6512edec48b2ccfe9bb969ce26ebbbcd49de6c4b
Author: Deepa Dinamani <deepa.kernel@gmail.com>
Date:   Wed Oct 21 18:42:37 2015 -0700

    staging: ft1000: remove obsolete driver
    
    Remove support for Qleadtek Flash-OFDM modems. Telecom carrier is
    discontinuing service for the radio technology.
    See http://www.gtigroup.org/news/ind/2015-08-18/6996.html.
    
    Suggested-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
    Acked-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
----------------------------------------------

> This is an odd request to make of yourself in public, or was this a
> script gone wrong?

It was not a script gone wrong, though the output and emails
were scripted.

> confused,

No worries, it's easy to miss stuff.

fyi: the silly script I wrote is attached

Done using the latest -next with an empty patterns directory

$ perl ./scripts/get_maintainer.pl --self-test=patterns | \
  cut -f2 -d: | \
  while read line ; do \
    perl ./dump_section.perl $line \
  done


[-- Attachment #2: dump_section.perl --]
[-- Type: application/x-perl, Size: 2579 bytes --]

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28 22:04 Joe Perches
2018-09-29  0:46 ` Greg Kroah-Hartman
2018-09-29  1:15   ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da894e81adc28ac98d9c399d24d8eb075b30fd1a.camel@perches.com \
    --to=joe@perches.com \
    --cc=arnd@arndb.de \
    --cc=deepa.kernel@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.belisko@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git
	git clone --mirror https://lore.kernel.org/lkml/10 lkml/git/10.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git