From: Frank Rowand <frowand.list@gmail.com>
To: Brendan Higgins <brendanhiggins@google.com>,
jdike@addtoit.com, richard@nod.at,
anton.ivanov@cambridgegreys.com, arnd@arndb.de,
keescook@chromium.org, skhan@linuxfoundation.org,
alan.maguire@oracle.com, yzaikin@google.com, davidgow@google.com,
akpm@linux-foundation.org, rppt@linux.ibm.com
Cc: gregkh@linuxfoundation.org, sboyd@kernel.org,
logang@deltatee.com, mcgrof@kernel.org,
linux-um@lists.infradead.org, linux-arch@vger.kernel.org,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 0/7] kunit: create a centralized executor to dispatch all KUnit tests
Date: Mon, 2 Mar 2020 11:41:39 -0600 [thread overview]
Message-ID: <da91797a-8640-12c7-8265-94586aacfa4c@gmail.com> (raw)
In-Reply-To: <20200228012036.15682-1-brendanhiggins@google.com>
On 2/27/20 7:20 PM, Brendan Higgins wrote:
> ## TL;DR
>
> This patchset adds a centralized executor to dispatch tests rather than
> relying on late_initcall to schedule each test suite separately along
> with a couple of new features that depend on it.
>
> Also, sorry for the delay in getting this new revision out. I have been
> really busy for the past couple weeks.
>
> ## What am I trying to do?
>
> Conceptually, I am trying to provide a mechanism by which test suites
> can be grouped together so that they can be reasoned about collectively.
> The last two of three patches in this series add features which depend
> on this:
>
> PATCH 5/7 Prints out a test plan[1] right before KUnit tests are run;
> this is valuable because it makes it possible for a test
> harness to detect whether the number of tests run matches the
> number of tests expected to be run, ensuring that no tests
> silently failed. The test plan includes a count of tests that
> will run. With the centralized executor, the tests are located
> in a single data structure and thus can be counted.
>
> PATCH 6/7 Add a new kernel command-line option which allows the user to
> specify that the kernel poweroff, halt, or reboot after
> completing all KUnit tests; this is very handy for running
> KUnit tests on UML or a VM so that the UML/VM process exits
> cleanly immediately after running all tests without needing a
> special initramfs. The centralized executor provides a
> definitive point when all tests have completed and the
> poweroff, halt, or reboot could occur.
>
> In addition, by dispatching tests from a single location, we can
> guarantee that all KUnit tests run after late_init is complete, which
> was a concern during the initial KUnit patchset review (this has not
> been a problem in practice, but resolving with certainty is nevertheless
> desirable).
>
> Other use cases for this exist, but the above features should provide an
> idea of the value that this could provide.
>
> ## Changes since last revision:
> - On patch 7/7, I added some additional wording around the
> kunit_shutdown command line option explaining that it runs after
> built-in tests as suggested by Frank.
> - On the coverletter, I improved some wording and added a missing link.
> I also specified the base-commit for the series.
> - Frank asked for some changes to the documentation; however, David is
> taking care of that in a separate patch[2], so I did not make those
> changes here. There will be some additional changes necessary
> after David's patch is applied.
Making the documentation changes after David's patches sounds like
a good plan to me.
-Frank
>
> Alan Maguire (1):
> kunit: test: create a single centralized executor for all tests
>
> Brendan Higgins (5):
> vmlinux.lds.h: add linker section for KUnit test suites
> arch: um: add linker section for KUnit test suites
> init: main: add KUnit to kernel init
> kunit: test: add test plan to KUnit TAP format
> Documentation: Add kunit_shutdown to kernel-parameters.txt
>
> David Gow (1):
> kunit: Add 'kunit_shutdown' option
>
> .../admin-guide/kernel-parameters.txt | 8 ++
> arch/um/include/asm/common.lds.S | 4 +
> include/asm-generic/vmlinux.lds.h | 8 ++
> include/kunit/test.h | 82 ++++++++++++-------
> init/main.c | 4 +
> lib/kunit/Makefile | 3 +-
> lib/kunit/executor.c | 71 ++++++++++++++++
> lib/kunit/test.c | 11 ---
> tools/testing/kunit/kunit_kernel.py | 2 +-
> tools/testing/kunit/kunit_parser.py | 76 ++++++++++++++---
> .../test_is_test_passed-all_passed.log | 1 +
> .../test_data/test_is_test_passed-crash.log | 1 +
> .../test_data/test_is_test_passed-failure.log | 1 +
> 13 files changed, 218 insertions(+), 54 deletions(-)
> create mode 100644 lib/kunit/executor.c
>
>
> base-commit: a2f0b878c3ca531a1706cb2a8b079cea3b17bafc
>
> [1] https://github.com/isaacs/testanything.github.io/blob/tap14/tap-version-14-specification.md#the-plan
> [2] https://patchwork.kernel.org/patch/11383635/
>
next prev parent reply other threads:[~2020-03-02 17:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 1:20 [PATCH v3 0/7] kunit: create a centralized executor to dispatch all KUnit tests Brendan Higgins
2020-02-28 1:20 ` [PATCH v3 1/7] vmlinux.lds.h: add linker section for KUnit test suites Brendan Higgins
2020-02-28 7:22 ` Brendan Higgins
2020-02-28 17:53 ` Iurii Zaikin
2020-02-28 1:20 ` [PATCH v3 2/7] arch: um: " Brendan Higgins
2020-02-28 1:20 ` [PATCH v3 3/7] kunit: test: create a single centralized executor for all tests Brendan Higgins
2020-02-28 1:20 ` [PATCH v3 4/7] init: main: add KUnit to kernel init Brendan Higgins
2020-03-02 19:13 ` Frank Rowand
2020-06-24 20:15 ` Brendan Higgins
2020-03-02 22:45 ` Kees Cook
2020-06-24 20:20 ` Brendan Higgins
2020-06-24 20:48 ` Kees Cook
2020-02-28 1:20 ` [PATCH v3 5/7] kunit: test: add test plan to KUnit TAP format Brendan Higgins
2020-02-28 1:20 ` [PATCH v3 6/7] kunit: Add 'kunit_shutdown' option Brendan Higgins
2020-02-28 1:20 ` [PATCH v3 7/7] Documentation: Add kunit_shutdown to kernel-parameters.txt Brendan Higgins
2020-03-04 23:10 ` Randy Dunlap
2020-03-02 17:41 ` Frank Rowand [this message]
2020-03-02 20:03 ` [PATCH v3 0/7] kunit: create a centralized executor to dispatch all KUnit tests Luis Chamberlain
2020-03-02 21:16 ` Guenter Roeck
2020-03-02 22:19 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da91797a-8640-12c7-8265-94586aacfa4c@gmail.com \
--to=frowand.list@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan.maguire@oracle.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=arnd@arndb.de \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdike@addtoit.com \
--cc=keescook@chromium.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=logang@deltatee.com \
--cc=mcgrof@kernel.org \
--cc=richard@nod.at \
--cc=rppt@linux.ibm.com \
--cc=sboyd@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).