From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753119AbcJCOZ7 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 3 Oct 2016 10:25:59 -0400
Received: from mout.web.de ([212.227.17.11]:54943 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753007AbcJCOZw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Oct 2016 10:25:52 -0400
Subject: Re: KVM: s390: Use memdup_user() rather than duplicating code
To: Geert Uytterhoeven <geert@linux-m68k.org>
References: <82b84c9c-38a4-4d17-910f-312668dbae01@users.sourceforge.net>
 <bb710b21-d8c4-e172-63d4-b46c80645cb3@users.sourceforge.net>
 <ddb2bbd9-757b-fc62-8642-ce827a7a666d@de.ibm.com>
 <e72e9854-443b-7033-d674-8a2d237600ca@users.sourceforge.net>
 <c86f7520-885e-2829-ae9c-b81caa898e84@users.sourceforge.net>
 <CAMuHMdVX6RKZYQyOrX35D+EKoRH6ZFAkyiC=BKnyKtE1Ph4t8g@mail.gmail.com>
 <73d5a586-2178-a311-f19c-c16c6e8cbb22@users.sourceforge.net>
 <CAMuHMdWgCBmObqfhkrtZPXjYqK7sA0DWeLzTV18hqKpevu1MeA@mail.gmail.com>
 <9ee60162-110b-1305-5a97-624de425d072@users.sourceforge.net>
 <CAMuHMdUS2aMd5B2nQOpQFdQGE7EvWMCea+dMzS7R7_yZ4LdONw@mail.gmail.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
        =?UTF-8?Q?Christian_Borntr=c3=a4ger?= <borntraeger@de.ibm.com>,
        Cornelia Huck <cornelia.huck@de.ibm.com>,
        David Hildenbrand <dahi@linux.vnet.ibm.com>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>, Walter Harms <wharms@bfs.de>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <da96837e-50bb-de1e-be42-0a22474edee8@users.sourceforge.net>
Date: Mon, 3 Oct 2016 16:25:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <CAMuHMdUS2aMd5B2nQOpQFdQGE7EvWMCea+dMzS7R7_yZ4LdONw@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:V6o9JC9PMG++7KlL2GlDDt2EEuZpMUfBlFF/bxXv1NgzrPvLAtX
 QTAukI0Dx8kDX6t4OuPE+25RKsk08Wd9ZK1XQKXT4WupVXziBii6MGzEBKy3N0IGWVh9njg
 zFyoFcqMxtgg7SoBF1FuhjZ64ffN0GzNf41bTzbJGlnrhKfEtCP7g5QlmHcOczOov8HT5S4
 fRp4qveaOOF0+XsQSd+EQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:vHwfbk/ssHk=:yVfRWD7XUSXEJAmiKp2ffN
 glCPfrqethRAiNjW0fRTk7Wy9+kjU5c4sSvUG1/Vs64GjyC0u5bzVKQn5d+bPcjaSarDy4PQe
 Pr/a2iXSyC/5o49Mboq0hrhgThnR3MctL7Ctcd/osrR4B7EhGc9ID6cVUGu+AkKSgxFpAESVS
 pS1MNsEpIQyJXyxtEm//LhyxigWteNNw1Lr8IrIf2DAdtbMqkXK6z3XgUfGvNn9iUAKfw2iKd
 XzzD020nyW/+50FB3NWt7D6xqUuFcpgWLk6zqaKcCSYzn+c6S+wFeFUib7rx6pwd/dv5UBC+s
 NhnTAcbtwQlHfe5tEY4MnmaPGz6yObx9MJhJwuf2bCabydHngfFa+qkKDQaizaOjYvw6/BGwZ
 Qn1yOVX91lE2XXIbKSip6oO4BwLAWZggT+9i1IFiy4YO23suNFfI2SGCXt1Q42DpajyHK0u6M
 +K/ugT8IDeeex/bAcLYtaEHo27eV0w0mkfbnTpn752RvKGoZojQCw8x/BOEqT9qwFAEBR5w9I
 q+vd+JDrSPHuelcDS8TTBgHKs1WdARdeXcbZtHkdFBvHxRDnm0eOop0z27UZ2I5UPPURjnmF5
 9Mr4wG3ojtonZLj3fxWE4OXFnCB79vuO+Pju0I1pDMMFCjxaPAnnISdGLJ01Mebg7J6CY/V8T
 trjJIbmdxVp1d3cBZnDX4jpbHVTJ3EOhcg9nPPB8hS6J4A94Gm1PXEmvTb4FpI2EWo1TPVnmZ
 9/snYIRiF19wiUvVfgX9HCi630N0Sd1PHo3KFEziZ+FvgmwWtKIkkdZ/F5L9yg0lFZQdIFyda
 BDtHi1b
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> * Does there really a probability remain that an inappropriate product
>>   would be calculated here (as the situation was before my two update steps
>>   for this software module)?
> 
> Perhaps not. Hence my "Probably not an issue here, ...".

Thanks for your clarification.


>> * Can it be that you are looking for a variant of a function like "memdup_user"
>>   where values can be passed as separate parameters "count" and "size" so that
>>   the needed multiplication and corresponding overflow check would be performed
>>   together as desired?
> 
> If there are enough uses, and people like it, adding memdup_user_array()
> may be a good idea...

How are the chances of such an addition for the Linux programming interface?


> P.S. Why do your questions make me think of a scientific paper? ;-)

Would you like to recommend any for further reading?   ;-)

Regards,
Markus