From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752431AbeDCQYR (ORCPT ); Tue, 3 Apr 2018 12:24:17 -0400 Received: from smtp62.i.mail.ru ([217.69.128.42]:33334 "EHLO smtp62.i.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbeDCQYQ (ORCPT ); Tue, 3 Apr 2018 12:24:16 -0400 Subject: Re: [PATCH v2 1/6] spi: core: handle timeout error from transfer_one() To: Mark Brown Cc: Maxime Ripard , Chen-Yu Tsai , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20180403152905.1524-1-ssuloev@orpaltech.com> <20180403152905.1524-2-ssuloev@orpaltech.com> <20180403155224.GA11578@sirena.org.uk> <20180403161824.GB11578@sirena.org.uk> From: Sergey Suloev Message-ID: Date: Tue, 3 Apr 2018 19:24:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180403161824.GB11578@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Authentication-Results: smtp62.i.mail.ru; auth=pass smtp.auth=ssuloev@orpaltech.com smtp.mailfrom=ssuloev@orpaltech.com X-7FA49CB5: 0D63561A33F958A5FD29AC8487AFC76645D69CFE915011F8C0A55FB0EC7263FE725E5C173C3A84C30584FF81F342DA07CE36787672731931D028CC0B556B22BCC4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F05F538519369F3743B503F486389A921A5CC5B56E945C8DA X-Mailru-Sender: C5364AD02485212F3ACDC11E67D8491782A192941C52799AE31CBED767B1E567069BFC61DABEEB110841D3AAAB1726C63DDE9B364B0DF289264D2CD8C2503E8C22A194DADEED8EEDCA01A23BA9CD1BE7ED14614B50AE0675 X-Mras: OK Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2018 07:18 PM, Mark Brown wrote: > On Tue, Apr 03, 2018 at 07:00:55PM +0300, Sergey Suloev wrote: >> On 04/03/2018 06:52 PM, Mark Brown wrote: >>> On Tue, Apr 03, 2018 at 06:29:00PM +0300, Sergey Suloev wrote: >>>> As long as sun4i/sun6i SPI drivers have overriden the default >>>> "wait for completion" procedure then we need to properly >>>> handle -ETIMEDOUT error from transfer_one(). >>> Why is this connected to those drivers specifically? >> These 2 drivers have their own "waiting" code and not using the code from >> SPI core. > Does this not apply to any other driver - why is this something we only > have to do when these drivers do it? That's what's setting off alarm > bells. sun4i/sun6i drivers have let's say "smart" waiting while SPI core uses a fixed interval to wait. I can't say for every SPI driver in kernel, that's outside of my area of expertise.