From: "luobin (L)" <luobin9@huawei.com>
To: Wei Li <liwei391@huawei.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<huawei.libin@huawei.com>, <guohanjun@huawei.com>
Subject: Re: [PATCH] hinic: fix potential resource leak
Date: Thu, 17 Sep 2020 11:44:11 +0800 [thread overview]
Message-ID: <dadc79e3-a923-7a4a-2d6f-3f33d614591e@huawei.com> (raw)
In-Reply-To: <20200917030307.47195-1-liwei391@huawei.com>
On 2020/9/17 11:03, Wei Li wrote:
> + err = irq_set_affinity_hint(rq->irq, &rq->affinity_mask);
> + if (err)
> + goto err_irq;
> +
> + return 0;
> +
> +err_irq:
> + rx_del_napi(rxq);
> + return err;
If irq_set_affinity_hint fails, irq should be freed as well.
next prev parent reply other threads:[~2020-09-17 3:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 3:03 [PATCH] hinic: fix potential resource leak Wei Li
2020-09-17 3:44 ` luobin (L) [this message]
2020-09-17 3:55 ` liwei (GF)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dadc79e3-a923-7a4a-2d6f-3f33d614591e@huawei.com \
--to=luobin9@huawei.com \
--cc=davem@davemloft.net \
--cc=guohanjun@huawei.com \
--cc=huawei.libin@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).