From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85B3CC433FE for ; Tue, 15 Nov 2022 18:17:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231267AbiKOSRr (ORCPT ); Tue, 15 Nov 2022 13:17:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229836AbiKOSRo (ORCPT ); Tue, 15 Nov 2022 13:17:44 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE4342FC09 for ; Tue, 15 Nov 2022 10:16:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668536208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kj5gUGjnNL7HTJHnWGJEGP1r8ya+Z2yQIMJyOuFXDbI=; b=HltAKysOVtb7BlDe7fLuvsD630w8LnPJ7XW6UcZPN3VAxddg16MJD7FqNc1pSZ8hvUh9KO +bJdtgEBjjgFfiAt3OXYAuHGCcIX0y34zUN10O4//c1Fa2X+7Jd/1u+S2n+6bDeI6+ezyQ UwAq6qQdzFN1OiFCBNHpr63emnRu1Cw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-393-FtSZGeXyO3-C7Z-64Ka3Uw-1; Tue, 15 Nov 2022 13:16:38 -0500 X-MC-Unique: FtSZGeXyO3-C7Z-64Ka3Uw-1 Received: by mail-wm1-f72.google.com with SMTP id 186-20020a1c02c3000000b003cfab28cbe0so10833972wmc.9 for ; Tue, 15 Nov 2022 10:16:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Kj5gUGjnNL7HTJHnWGJEGP1r8ya+Z2yQIMJyOuFXDbI=; b=xRXH9zCMvlnkTZYtPCMxYXiAsOp9d2hzdCz3VpX784QoMMeeo7pZEyE1TC5tnx3eKp 0A133VoRqT2yoU06O48pxfq49oVb2HwWM5KEiIQueIHnLUHbtWu58X3WRnWWBMUgLipz LO3ovumQkat1hCGJ8j1mgGaUDlCOKWE+BtTeWCd6jn3WVmkWvdhIFiKwwIvLpCg/r1fz dTWM59JQTs4dmvNeUoHTyiOA/hwKomCSJzAaJg4kH537E/qtr4wF2zB8k+L7FcHSeOuL t+HtdfdAFzxYXNivTXwkNpQXbQzoUswkZjPy78eVhfZzmYChNRLbJjej78+jm8vXOGpP JVzQ== X-Gm-Message-State: ANoB5pm9HBo62iqoxBE9qTPaQqXcWSefNWZCHojFAijMgVdVuDn00jOa +dAHF+ryidv1U4EW6Ru/T9wafkhlnFarPQ60dJE164/PCoEpq9Cq9SR/hAcMt7WfBGQcIqghC4g /2Y+rJJn/ePrZmei8hqyspe2t X-Received: by 2002:a7b:c4c7:0:b0:3cf:d58f:f66e with SMTP id g7-20020a7bc4c7000000b003cfd58ff66emr1324756wmk.165.1668536197461; Tue, 15 Nov 2022 10:16:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf6AVO/NeUZORJwsG145z9PSzkGDH22DT4G3Auyd7YAlI8y6wYKkqYr2uJDocMHWZjck43jIAQ== X-Received: by 2002:a7b:c4c7:0:b0:3cf:d58f:f66e with SMTP id g7-20020a7bc4c7000000b003cfd58ff66emr1324747wmk.165.1668536197223; Tue, 15 Nov 2022 10:16:37 -0800 (PST) Received: from ?IPV6:2003:cb:c707:9d00:9303:90ce:6dcb:2bc9? (p200300cbc7079d00930390ce6dcb2bc9.dip0.t-ipconnect.de. [2003:cb:c707:9d00:9303:90ce:6dcb:2bc9]) by smtp.gmail.com with ESMTPSA id c7-20020a1c3507000000b003c6f1732f65sm21054960wma.38.2022.11.15.10.16.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 10:16:36 -0800 (PST) Message-ID: Date: Tue, 15 Nov 2022 19:16:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v2 1/2] mm/migrate: Fix read-only page got writable when recover pte Content-Language: en-US To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrea Arcangeli , Axel Rasmussen , Ives van Hoorne , Nadav Amit , Andrew Morton , Mike Rapoport , stable@vger.kernel.org References: <20221110203132.1498183-1-peterx@redhat.com> <20221110203132.1498183-2-peterx@redhat.com> <9af36be3-313b-e39c-85bb-bf30011bccb8@redhat.com> <82d7a142-8c78-4168-37e9-7b677b18987a@redhat.com> <2ed12722-2359-cb07-53e7-566d959d311e@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15.11.22 19:11, Peter Xu wrote: > On Tue, Nov 15, 2022 at 06:54:09PM +0100, David Hildenbrand wrote: >> No it isn't natural. But sneaking such a change into your fix seems wrong. >> Touching !uffd-wp code should be separate, if we want to do this at all (as >> we discussed, maybe the better/cleaner approach is to eliminate writable >> migration entries if possible). > > If you see I made the subject as mm/migrate, because I took it as a > migration change, not uffd-wp specific. I also added the Fixes to the uffd > patch because afaict that's the only thing that it affects, but I can't > tell either. > > As I said, I'm trying to follow the rule where we have read entry I want to > make sure write bit removed. I really don't think we should do that generic change. -- Thanks, David / dhildenb