[PATCH] arm64: dts: mt8183: add cbas node under cros_ec

[PATCH] arm64: dts: mt8183: add cbas node under cros_ec

[Ikjoon Jang]

Add a 'cbas' device node for supporting table mode switch in
kukui devices.

Kukui platforms with detacheable base have an additional input
device under cros-ec, which reports SW_TABLET_MODE regarding
its base state (e.g. base flipped or detached).

Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
---

 arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index ff56bcfa3370..40030ed48854 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -816,6 +816,10 @@ usbc_extcon: extcon0 {
 			compatible = "google,extcon-usbc-cros-ec";
 			google,usb-port-id = <0>;
 		};
+
+		base_detection: cbas {
+			compatible = "google,cros-cbas";
+		};
 	};
 };
 
-- 
2.31.1.607.g51e8a6a459-goog

Re: [PATCH] arm64: dts: mt8183: add cbas node under cros_ec

[Matthias Brugger]

Hi Ikjoon,

On 10/05/2021 11:26, Ikjoon Jang wrote:
> Add a 'cbas' device node for supporting table mode switch in
> kukui devices.
> 
> Kukui platforms with detacheable base have an additional input
> device under cros-ec, which reports SW_TABLET_MODE regarding
> its base state (e.g. base flipped or detached).
> 
> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> ---
> 
>  arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index ff56bcfa3370..40030ed48854 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -816,6 +816,10 @@ usbc_extcon: extcon0 {
>  			compatible = "google,extcon-usbc-cros-ec";
>  			google,usb-port-id = <0>;
>  		};
> +
> +		base_detection: cbas {
> +			compatible = "google,cros-cbas";

I'm not able to find any binding description for this. It seems linux-next has
driver binding to this compatible, but the description is missing.

Can you please clarify.

Thanks,
Mathias

> +		};
>  	};
>  };
>  
> 

Re: [PATCH] arm64: dts: mt8183: add cbas node under cros_ec

[Ikjoon Jang]

On Thu, May 13, 2021 at 12:38 AM Matthias Brugger
<matthias.bgg@gmail.com> wrote:
>
> Hi Ikjoon,
>
> On 10/05/2021 11:26, Ikjoon Jang wrote:
> > Add a 'cbas' device node for supporting table mode switch in

tablet

> > kukui devices.
> >
> > Kukui platforms with detacheable base have an additional input
> > device under cros-ec, which reports SW_TABLET_MODE regarding
> > its base state (e.g. base flipped or detached).
> >
> > Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> > ---
> >
> >  arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > index ff56bcfa3370..40030ed48854 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > @@ -816,6 +816,10 @@ usbc_extcon: extcon0 {
> >                       compatible = "google,extcon-usbc-cros-ec";
> >                       google,usb-port-id = <0>;
> >               };
> > +
> > +             base_detection: cbas {
> > +                     compatible = "google,cros-cbas";
>
> I'm not able to find any binding description for this. It seems linux-next has
> driver binding to this compatible, but the description is missing.
>
> Can you please clarify.

Yep, that's correct.
Let me resend this with v2 after the dt-binding patch is applied.

In this series, I requested queueing these to hid tree:

[v5, 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's switch device
https://patchwork.kernel.org/project/linux-input/patch/20210415032958.740233-2-ikjn@chromium.org/

[v5, 2/2] HID: google: Add of_match table to Whiskers switch device.
https://patchwork.kernel.org/project/linux-input/patch/20210415032958.740233-3-ikjn@chromium.org/

Later I found that I missed a comment from [v5, 1/2]
But only [v5, 2/2] part is already applied to hid tree as I asked for it.

I sent a v6 dt-binding patch is here (not yet applied)
https://patchwork.kernel.org/project/linux-input/patch/20210512100832.3878138-1-ikjn@chromium.org/

>
> Thanks,
> Mathias
>
> > +             };
> >       };
> >  };
> >
> >

Re: [PATCH] arm64: dts: mt8183: add cbas node under cros_ec

[Enric Balletbo i Serra]

Hi Ikjoon,

Thank you for the patch.

On 13/5/21 3:45, Ikjoon Jang wrote:
> On Thu, May 13, 2021 at 12:38 AM Matthias Brugger
> <matthias.bgg@gmail.com> wrote:
>>
>> Hi Ikjoon,
>>
>> On 10/05/2021 11:26, Ikjoon Jang wrote:
>>> Add a 'cbas' device node for supporting table mode switch in
> 
> tablet
> 
>>> kukui devices.
>>>
>>> Kukui platforms with detacheable base have an additional input
>>> device under cros-ec, which reports SW_TABLET_MODE regarding
>>> its base state (e.g. base flipped or detached).
>>>
>>> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
>>> ---
>>>
>>>  arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>> index ff56bcfa3370..40030ed48854 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>> @@ -816,6 +816,10 @@ usbc_extcon: extcon0 {
>>>                       compatible = "google,extcon-usbc-cros-ec";
>>>                       google,usb-port-id = <0>;
>>>               };
>>> +
>>> +             base_detection: cbas {


This should be just cbas, remove base_detection. It was a bit confusing follow
these series. If [v5, 2/2] is already applied in hid tree, I'd suggest send a v7
version including:

[v7, 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's switch device
[v7, 2/2] arm64: dts: mt8183: add cbas node under cros_ec

Both patches can go through the Matthias tree, but the first one also needs an
Ack from Lee Jones, MFD maintainer, which I think is not cc'ied, so unlikely to
give you the needed ack.

Thanks,
  Enric


>>> +                     compatible = "google,cros-cbas";
>>
>> I'm not able to find any binding description for this. It seems linux-next has
>> driver binding to this compatible, but the description is missing.
>>
>> Can you please clarify.
> 
> Yep, that's correct.
> Let me resend this with v2 after the dt-binding patch is applied.
> 
> In this series, I requested queueing these to hid tree:
> 
> [v5, 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's switch device
> https://patchwork.kernel.org/project/linux-input/patch/20210415032958.740233-2-ikjn@chromium.org/
> 
> [v5, 2/2] HID: google: Add of_match table to Whiskers switch device.
> https://patchwork.kernel.org/project/linux-input/patch/20210415032958.740233-3-ikjn@chromium.org/
> 
> Later I found that I missed a comment from [v5, 1/2]
> But only [v5, 2/2] part is already applied to hid tree as I asked for it.
> 
> I sent a v6 dt-binding patch is here (not yet applied)
> https://patchwork.kernel.org/project/linux-input/patch/20210512100832.3878138-1-ikjn@chromium.org/
> 
>>
>> Thanks,
>> Mathias
>>
>>> +             };
>>>       };
>>>  };
>>>
>>>

Re: [PATCH] arm64: dts: mt8183: add cbas node under cros_ec

[Ikjoon Jang]

On Fri, May 14, 2021 at 4:55 PM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Ikjoon,
>
> Thank you for the patch.
>
> On 13/5/21 3:45, Ikjoon Jang wrote:
> > On Thu, May 13, 2021 at 12:38 AM Matthias Brugger
> > <matthias.bgg@gmail.com> wrote:
> >>
> >> Hi Ikjoon,
> >>
> >> On 10/05/2021 11:26, Ikjoon Jang wrote:
> >>> Add a 'cbas' device node for supporting table mode switch in
> >
> > tablet
> >
> >>> kukui devices.
> >>>
> >>> Kukui platforms with detacheable base have an additional input
> >>> device under cros-ec, which reports SW_TABLET_MODE regarding
> >>> its base state (e.g. base flipped or detached).
> >>>
> >>> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> >>> ---
> >>>
> >>>  arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
> >>>  1 file changed, 4 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> >>> index ff56bcfa3370..40030ed48854 100644
> >>> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> >>> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> >>> @@ -816,6 +816,10 @@ usbc_extcon: extcon0 {
> >>>                       compatible = "google,extcon-usbc-cros-ec";
> >>>                       google,usb-port-id = <0>;
> >>>               };
> >>> +
> >>> +             base_detection: cbas {
>
>
> This should be just cbas, remove base_detection. It was a bit confusing follow
> these series. If [v5, 2/2] is already applied in hid tree, I'd suggest send a v7
> version including:
>
> [v7, 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's switch device
> [v7, 2/2] arm64: dts: mt8183: add cbas node under cros_ec

sure, let me upload v7 with dt-bindings + mt8183.dtsi together.

>
> Both patches can go through the Matthias tree, but the first one also needs an
> Ack from Lee Jones, MFD maintainer, which I think is not cc'ied, so unlikely to
> give you the needed ack.

Oops.. :-S
(Why did I think this should go through hid?)
Thanks a lot for pointing out the basic but critical mistake.

>
> Thanks,
>   Enric
>
>
> >>> +                     compatible = "google,cros-cbas";
> >>
> >> I'm not able to find any binding description for this. It seems linux-next has
> >> driver binding to this compatible, but the description is missing.
> >>
> >> Can you please clarify.
> >
> > Yep, that's correct.
> > Let me resend this with v2 after the dt-binding patch is applied.
> >
> > In this series, I requested queueing these to hid tree:
> >
> > [v5, 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's switch device
> > https://patchwork.kernel.org/project/linux-input/patch/20210415032958.740233-2-ikjn@chromium.org/
> >
> > [v5, 2/2] HID: google: Add of_match table to Whiskers switch device.
> > https://patchwork.kernel.org/project/linux-input/patch/20210415032958.740233-3-ikjn@chromium.org/
> >
> > Later I found that I missed a comment from [v5, 1/2]
> > But only [v5, 2/2] part is already applied to hid tree as I asked for it.
> >
> > I sent a v6 dt-binding patch is here (not yet applied)
> > https://patchwork.kernel.org/project/linux-input/patch/20210512100832.3878138-1-ikjn@chromium.org/
> >
> >>
> >> Thanks,
> >> Mathias
> >>
> >>> +             };
> >>>       };
> >>>  };
> >>>
> >>>

Re: [PATCH] arm64: dts: mt8183: add cbas node under cros_ec

[Matthias Brugger]

On 09/06/2021 05:25, Ikjoon Jang wrote:
> Add a 'cbas' device node for supporting tablet mode switch in
> kukui devices.
> 
> Kukui platforms with detacheable base have an additional input
> device under cros-ec, which reports SW_TABLET_MODE regarding
> its base state (e.g. base flipped or detached).
> 
> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>

Applied to v5.13-next/dts64

Thanks!

> 
> ---
> Resend this as a spin-off, other patches for dt-binding and
> hid driver were applied.
> 
> Link: https://lore.kernel.org/r/20210514122051.266169-1-ikjn@chromium.org/
> Link: https://lore.kernel.org/r/20210415032958.740233-1-ikjn@chromium.org/
> 
>  arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index ff56bcfa3370..1512605a438e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -816,6 +816,10 @@ usbc_extcon: extcon0 {
>  			compatible = "google,extcon-usbc-cros-ec";
>  			google,usb-port-id = <0>;
>  		};
> +
> +		cbas {
> +			compatible = "google,cros-cbas";
> +		};
>  	};
>  };
>  
> 

[PATCH] arm64: dts: mt8183: add cbas node under cros_ec

[Ikjoon Jang]

Add a 'cbas' device node for supporting tablet mode switch in
kukui devices.

Kukui platforms with detacheable base have an additional input
device under cros-ec, which reports SW_TABLET_MODE regarding
its base state (e.g. base flipped or detached).

Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>

---
Resend this as a spin-off, other patches for dt-binding and
hid driver were applied.

Link: https://lore.kernel.org/r/20210514122051.266169-1-ikjn@chromium.org/
Link: https://lore.kernel.org/r/20210415032958.740233-1-ikjn@chromium.org/

 arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index ff56bcfa3370..1512605a438e 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -816,6 +816,10 @@ usbc_extcon: extcon0 {
 			compatible = "google,extcon-usbc-cros-ec";
 			google,usb-port-id = <0>;
 		};
+
+		cbas {
+			compatible = "google,cros-cbas";
+		};
 	};
 };
 
-- 
2.32.0.rc1.229.g3e70b5a671-goog