From: Chao Yu <yuchao0@huawei.com>
To: Daeho Jeong <daeho43@gmail.com>, <linux-kernel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>,
<kernel-team@android.com>
Cc: Daeho Jeong <daehojeong@google.com>
Subject: Re: [PATCH] f2fs: protect new segment allocation in expand_inode_data
Date: Wed, 3 Jun 2020 14:58:46 +0800 [thread overview]
Message-ID: <daed6176-fb7d-bd4d-9662-735cc3cda2e0@huawei.com> (raw)
In-Reply-To: <20200601030347.112984-1-daeho43@gmail.com>
On 2020/6/1 11:03, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> Found a new segemnt allocation without f2fs_lock_op() in
> expand_inode_data(). So, when we do fallocate() for a pinned file
> and trigger checkpoint very frequently and simultaneously. F2FS gets
> stuck in the below code of do_checkpoint() forever.
>
> f2fs_sync_meta_pages(sbi, META, LONG_MAX, FS_CP_META_IO);
> /* Wait for all dirty meta pages to be submitted for IO */
> <= if fallocate() here,
> f2fs_wait_on_all_pages(sbi, F2FS_DIRTY_META); <= it'll wait forever.
>
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
Daeho,
I guess Jaegeuk could add the tag when merging this patch, we don't have
to resend the patch if there is no updates on code and message.
Thanks,
> ---
> fs/f2fs/file.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index f7de2a1da528..14ace885baa9 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1660,7 +1660,11 @@ static int expand_inode_data(struct inode *inode, loff_t offset,
>
> down_write(&sbi->pin_sem);
> map.m_seg_type = CURSEG_COLD_DATA_PINNED;
> +
> + f2fs_lock_op(sbi);
> f2fs_allocate_new_segments(sbi, CURSEG_COLD_DATA);
> + f2fs_unlock_op(sbi);
> +
> err = f2fs_map_blocks(inode, &map, 1, F2FS_GET_BLOCK_PRE_DIO);
> up_write(&sbi->pin_sem);
>
>
next prev parent reply other threads:[~2020-06-03 6:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 3:03 [PATCH] f2fs: protect new segment allocation in expand_inode_data Daeho Jeong
2020-06-03 6:58 ` Chao Yu [this message]
2020-06-03 7:06 ` Daeho Jeong
-- strict thread matches above, loose matches on Subject: below --
2020-05-27 4:02 Daeho Jeong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daed6176-fb7d-bd4d-9662-735cc3cda2e0@huawei.com \
--to=yuchao0@huawei.com \
--cc=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).