From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B98EBC3F2D8 for ; Mon, 2 Mar 2020 11:57:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92844214DB for ; Mon, 2 Mar 2020 11:57:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727784AbgCBL5X (ORCPT ); Mon, 2 Mar 2020 06:57:23 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:46439 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727228AbgCBL5X (ORCPT ); Mon, 2 Mar 2020 06:57:23 -0500 X-Originating-IP: 83.155.44.161 Received: from classic (mon69-7-83-155-44-161.fbx.proxad.net [83.155.44.161]) (Authenticated sender: hadess@hadess.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id E4BE340016; Mon, 2 Mar 2020 11:57:18 +0000 (UTC) Message-ID: Subject: Re: [PATCH v3 2/2] touchscreen: goodix: define GPIO mapping for GPD P2 Max From: Bastien Nocera To: Peter Cai , Hans de Goede Cc: Andy Shevchenko , Mika Westerberg , Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Date: Mon, 02 Mar 2020 12:57:18 +0100 In-Reply-To: <20190902124352.12291-2-peter@typeblog.net> References: <20190831030916.13172-1-peter@typeblog.net> <20190902124352.12291-1-peter@typeblog.net> <20190902124352.12291-2-peter@typeblog.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.35.91 (3.35.91-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-09-02 at 20:43 +0800, Peter Cai wrote: > The firmware of GPD P2 Max could not handle panel resets although > code > is present in DSDT. The kernel needs to take on this job instead, but > the DSDT does not provide _DSD, rendering kernel helpless when trying > to > find the respective GPIO pins. > > Fortunately, this time GPD has proper DMI vendor / product strings > that > we could match against. We simply apply an acpi_gpio_mapping table > when > GPD P2 Max is matched. > > Additionally, the DSDT definition of the irq pin specifies a wrong > polarity. The new quirk introduced in the previous patch > (ACPI_GPIO_QUIRK_OVERRIDE_POLARITY) is applied to correct this. Hans has posted a patchset which reworks GPIO access for ACPI devices. Could you please check whether you could rebase your patch on top of that? I also think the comment in "Input: goodix - Add support for getting IRQ + reset GPIOs on Cherry Trail devices" might also be of use: + case irq_pin_access_acpi_gpio: + /* + * The IRQ pin triggers on a falling edge, so its gets marked + * as active-low, use output_raw to avoid the value inversion. + */ Cheers