From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D31C47404 for ; Wed, 9 Oct 2019 15:57:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94348206BB for ; Wed, 9 Oct 2019 15:57:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731582AbfJIP5k (ORCPT ); Wed, 9 Oct 2019 11:57:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36526 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730708AbfJIP5k (ORCPT ); Wed, 9 Oct 2019 11:57:40 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BEDC458 for ; Wed, 9 Oct 2019 15:57:39 +0000 (UTC) Received: by mail-wr1-f70.google.com with SMTP id 32so1307994wrk.15 for ; Wed, 09 Oct 2019 08:57:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=y3ptxyyHx0/qzXbUl9U/H+quIFMeBGhW5hUUCE/0MjM=; b=LHZpNHS6AQ+vANZPM9vSNkkciAktkK6zK+CHiE6KkdnMeAyenih3HWVpX43DOCC4s6 uP8SStzjMi9Vd6c9xgBI68768T0CMWpJpmuJUBwQlfuwYqlDrwVObw+nHeTo7m3u7u3t i0BsfaAyu0lcuXS5r5YOzBUlwZx14OlyFZHd4JPiYfMdFCa/sEhRimCLYogvV6rrGQ7m a0gBLlfDUOEn1n58SXxAkXoYbXtTJBCt6alGJWZ/1fZ/3s62mnZRYQ5rloid70QWKSXI ZrsBfCRwLWx5+YcFDP65ntIxfqZu2jgVDHLkxgxCiNmtNjmLi2BWSpglmEjWrEarVx40 O4mQ== X-Gm-Message-State: APjAAAXzVRwb2oco1SwKJTN3/KQsKhy9uJThwwZ0R2FUYvkfm1fyvHDW ca0BuCixqq+BCRCftphI9v10dw9Rad3Ek32ijMaqKNctQvUvVAaEaBmuuFAWylC08FvJw55P7c3 NoFsz/Dk54vmrFcRLTnA04Z2e X-Received: by 2002:adf:dc8c:: with SMTP id r12mr3468314wrj.107.1570636658567; Wed, 09 Oct 2019 08:57:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqw+wX+0Fvu5SZNmKleHQuTrQYzbUMiEsd1/1OUnhTlZ4mxXcbH5/HWJm+m8uqOx261atg4O6A== X-Received: by 2002:adf:dc8c:: with SMTP id r12mr3468273wrj.107.1570636658129; Wed, 09 Oct 2019 08:57:38 -0700 (PDT) Received: from shalem.localdomain (2001-1c00-0c14-2800-ec23-a060-24d5-2453.cable.dynamic.v6.ziggo.nl. [2001:1c00:c14:2800:ec23:a060:24d5:2453]) by smtp.gmail.com with ESMTPSA id a10sm3027406wrm.52.2019.10.09.08.57.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Oct 2019 08:57:37 -0700 (PDT) Subject: Re: [PATCH] x86/mce: Lower throttling MCE messages to warnings To: Benjamin Berg , linux-kernel@vger.kernel.org Cc: Srinivas Pandruvada , Christian Kellner , Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-edac@vger.kernel.org References: <20191009155424.249277-1-bberg@redhat.com> From: Hans de Goede Message-ID: Date: Wed, 9 Oct 2019 17:57:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191009155424.249277-1-bberg@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 09-10-2019 17:54, Benjamin Berg wrote: > On modern CPUs it is quite normal that the temperature limits are > reached and the CPU is throttled. In fact, often the thermal design is > not sufficient to cool the CPU at full load and limits can quickly be > reached when a burst in load happens. This will even happen with > technologies like RAPL limitting the long term power consumption of > the package. > > So these messages do not usually indicate a hardware issue (e.g. > insufficient cooling). Log them as warnings to avoid confusion about > their severity. > > Signed-off-by: Benjamin Berg > Tested-by: Christian Kellner Ah, yes lets please lower the log-prio of these messages: Reviewed-by: Hans de Goede Regards, Hans > --- > arch/x86/kernel/cpu/mce/therm_throt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/cpu/mce/therm_throt.c b/arch/x86/kernel/cpu/mce/therm_throt.c > index 6e2becf547c5..bc441d68d060 100644 > --- a/arch/x86/kernel/cpu/mce/therm_throt.c > +++ b/arch/x86/kernel/cpu/mce/therm_throt.c > @@ -188,7 +188,7 @@ static void therm_throt_process(bool new_event, int event, int level) > /* if we just entered the thermal event */ > if (new_event) { > if (event == THERMAL_THROTTLING_EVENT) > - pr_crit("CPU%d: %s temperature above threshold, cpu clock throttled (total events = %lu)\n", > + pr_warn("CPU%d: %s temperature above threshold, cpu clock throttled (total events = %lu)\n", > this_cpu, > level == CORE_LEVEL ? "Core" : "Package", > state->count); >