From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47FFFC77B61 for ; Fri, 28 Apr 2023 11:44:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345857AbjD1Lo2 (ORCPT ); Fri, 28 Apr 2023 07:44:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230145AbjD1LoZ (ORCPT ); Fri, 28 Apr 2023 07:44:25 -0400 Received: from forward502a.mail.yandex.net (forward502a.mail.yandex.net [178.154.239.82]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78BD055A3; Fri, 28 Apr 2023 04:44:23 -0700 (PDT) Received: from mail-nwsmtp-smtp-production-main-84.vla.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-84.vla.yp-c.yandex.net [IPv6:2a02:6b8:c0f:26a7:0:640:a2d5:0]) by forward502a.mail.yandex.net (Yandex) with ESMTP id 7926E5EB96; Fri, 28 Apr 2023 14:44:21 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-84.vla.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id KiHVIE1Ba8c0-kLMgT63n; Fri, 28 Apr 2023 14:44:21 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maquefel.me; s=mail; t=1682682261; bh=P5dAEFXCyQi6+rdwlxT4TYQBkm3BseljpBsRS20Ci8M=; h=References:Date:In-Reply-To:Cc:To:From:Subject:Message-ID; b=GOJgSUi30rxJXVvgNEnAr96wjzGSIXWH0TV+ZOfFqq17/ayGyrdh/jHhwg7442ixu bYUDrbIcdC7sBc+aeLcre2Cl1uQzgM88pmN3dYEs5zokzhQEQ0zt91rp1FubbCtv3O DNL/PvTtQWYXxbU4lmFTcdczNuQPrwAgEWEYq+80= Authentication-Results: mail-nwsmtp-smtp-production-main-84.vla.yp-c.yandex.net; dkim=pass header.i=@maquefel.me Message-ID: Subject: Re: [PATCH 32/43] dt-bindings: gpio: Add DT bindings ep93xx gpio From: Nikita Shubin To: Linus Walleij , Rob Herring Cc: Arnd Bergmann , Linus Walleij , Alexander Sverdlin , Bartosz Golaszewski , Krzysztof Kozlowski , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 28 Apr 2023 17:44:22 +0300 In-Reply-To: References: <20230424123522.18302-1-nikita.shubin@maquefel.me> <20230424123522.18302-33-nikita.shubin@maquefel.me> <20230424163203.GK2701399-robh@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Linus! On Wed, 2023-04-26 at 22:48 +0200, Linus Walleij wrote: > On Mon, Apr 24, 2023 at 6:32=E2=80=AFPM Rob Herring wro= te: > > On Mon, Apr 24, 2023 at 03:34:48PM +0300, Nikita Shubin wrote: >=20 > > > Add YAML bindings for ep93xx SoC. > > >=20 > > > Signed-off-by: Nikita Shubin > (...) > > > +=C2=A0 chip-label: > > > +=C2=A0=C2=A0=C2=A0 maxItems: 1 > > > +=C2=A0=C2=A0=C2=A0 description: human readable name. > >=20 > > Why do you need this? It's not standard and I don't see other GPIO > > controllers needing it. >=20 > Caught my eye too, Nikita can you live without this and just use > dev_name() > or something to name the chip in Linux? >=20 > If it is to conform to EP93xx documentation naming I guess it should > be > cirrus,ep93xx-gpio-chip-name =3D "..."; ? Nah, i should drop it, it was a reverence to people which are sad about gpio index reordering. Through i like the idea of "cirrus,ep93xx-gpio-chip-name". >=20 > Yours, > Linus Walleij