From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53E40C46461 for ; Mon, 30 Jul 2018 03:57:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 018B420870 for ; Mon, 30 Jul 2018 03:57:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 018B420870 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726441AbeG3Faa (ORCPT ); Mon, 30 Jul 2018 01:30:30 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:10178 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725911AbeG3Fa3 (ORCPT ); Mon, 30 Jul 2018 01:30:29 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id B4F5C9294193A; Mon, 30 Jul 2018 11:57:28 +0800 (CST) Received: from [10.151.23.176] (10.151.23.176) by smtp.huawei.com (10.3.19.209) with Microsoft SMTP Server (TLS) id 14.3.399.0; Mon, 30 Jul 2018 11:57:20 +0800 Subject: Re: [PATCH 1/2] staging: erofs: fix compile error without built-in decompression support To: Chao Yu , Greg Kroah-Hartman , Chao Yu , Gao Xiang CC: , , References: <1532761832-6964-1-git-send-email-gaoxiang25@huawei.com> <20180729053459.34140-1-hsiangkao@aol.com> <5a396128-822f-5232-f3ee-1c5ac6524380@huawei.com> <614f3148-91ae-2a9a-f932-21e32e290717@huawei.com> From: Gao Xiang Message-ID: Date: Mon, 30 Jul 2018 11:55:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.151.23.176] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/7/30 11:07, Chao Yu wrote: >> It seems that Greg merged this patch to staging-next yesterday, since it is a urgent fix >> (otherwise erofs cannot be compiled properly without CONFIG_EROFS_FS_ZIP, that is my fault). >> >> I wrote in a patch yesterday becuase all the modifications have the same root cause ---- >> fix incorrect code snippets due to spilt code into small patches by mistake. >> >> But you are right, it is more proper to spilt into two patches, let me resend these patches later >> (I don't know whether Greg will apply them... :-( sorry... ) >> >> I think in order to reduce Greg's patchwork burden, we could quickly review patches internally in linux-erofs first, >> tidy up in a patchset set and send to Greg in a series periodically (if patches are not urgent). >> >> How do you think about it? > I agree with you, as we discussed offline, let's send patch to erofs mailing > list for review first, and keep all developing patches in erofs-dev branch as > long as possible, then periodically, submitting patches to Greg in batch, it can > reduce unneeded modification in staging-next tree. For urgent fix, we can speed > up the progress. :) > > Thanks, > Hi Greg, Sorry about patch annoying... We will send patches in batch periodically after "[PATCH] staging: erofs: use the wrapped PTR_ERR_OR_ZERO instead of open code". Before that, We will review these patches in the linux-erofs mailing list first... Hi Chao, OK, I just send new patches as your suggestion, could you please review again? (But I think it could not be re-merged by Greg's again... since no code changes, but the following patches will be upstreamed as we disscussed this morning...) And could you review '[PATCH] staging: erofs: use the wrapped PTR_ERR_OR_ZERO instead of open code' I just sent in the morning? Thanks, Gao Xiang