From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, Viresh Kumar <vireshk@kernel.org>,
Nishanth Menon <nm@ti.com>, Stephen Boyd <sboyd@kernel.org>,
Mark Brown <broonie@kernel.org>,
Dmitry Osipenko <digetx@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kamil Konieczny <k.konieczny@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH] opp: core: Revert "add regulators enable and disable"
Date: Fri, 18 Oct 2019 09:11:56 +0200 [thread overview]
Message-ID: <db377033-3d1d-f8c7-b0c0-5a7359022a62@samsung.com> (raw)
In-Reply-To: <20191018043026.xm7a6emczm6w7bck@vireshk-i7>
On 18.10.2019 06:30, Viresh Kumar wrote:
> On 17-10-19, 12:27, Marek Szyprowski wrote:
>> All the drivers, which use the OPP framework control regulators, which
>> are already enabled. Typically those regulators are also system critical,
>> due to providing power to CPU core or system buses. It turned out that
>> there are cases, where calling regulator_enable() on such boot-enabled
>> regulator has side-effects and might change its initial voltage due to
>> performing initial voltage balancing without all restrictions from the
>> consumers. Until this issue becomes finally solved in regulator core,
>> avoid calling regulator_enable()/disable() from the OPP framework.
>>
>> This reverts commit 7f93ff73f7c8c8bfa6be33bcc16470b0b44682aa.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>> This is a follow-up from the following discussion:
>> https://lkml.org/lkml/2019/10/9/541
> I suppose this must go the v5.4-rcs, right ?
Yes, please.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2019-10-18 7:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191017102843eucas1p164993b3644d006481fb041e36175eebe@eucas1p1.samsung.com>
2019-10-17 10:27 ` [PATCH] opp: core: Revert "add regulators enable and disable" Marek Szyprowski
2019-10-18 4:30 ` Viresh Kumar
2019-10-18 7:11 ` Marek Szyprowski [this message]
2019-10-18 11:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db377033-3d1d-f8c7-b0c0-5a7359022a62@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=digetx@gmail.com \
--cc=k.konieczny@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=nm@ti.com \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).