linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	thierry.reding@gmail.com, jonathanh@nvidia.com,
	frankc@nvidia.com, sakari.ailus@iki.fi,
	helen.koike@collabora.com
Cc: sboyd@kernel.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v9 6/9] media: tegra: Add Tegra210 Video input driver
Date: Fri, 24 Apr 2020 01:55:27 +0300	[thread overview]
Message-ID: <db413479-1557-3c40-ecb2-5a0c657065b6@gmail.com> (raw)
In-Reply-To: <3115a959-045e-7b27-94fb-a11a8b5f4a6a@nvidia.com>

23.04.2020 19:50, Sowjanya Komatineni пишет:
> 
> On 4/23/20 12:48 AM, Hans Verkuil wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 22/04/2020 08:18, Sowjanya Komatineni wrote:
>>> Tegra210 contains a powerful Video Input (VI) hardware controller
>>> which can support up to 6 MIPI CSI camera sensors.
>>>
>>> Each Tegra CSI port can be one-to-one mapped to VI channel and can
>>> capture from an external camera sensor connected to CSI or from
>>> built-in test pattern generator.
>>>
>>> Tegra210 supports built-in test pattern generator from CSI to VI.
>>>
>>> This patch adds a v4l2 capture driver with media interface for
>>> Tegra210 built-in CSI to VI test pattern generator.
>>>
>>> This patch includes TPG support only and all the video pipeline
>>> configuration happens through the video device node.
>>>
>>> Acked-by: Thierry Reding <treding@nvidia.com>
>>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>>> ---
>>>   drivers/staging/media/Kconfig          |    2 +
>>>   drivers/staging/media/Makefile         |    1 +
>>>   drivers/staging/media/tegra/Kconfig    |   13 +
>>>   drivers/staging/media/tegra/Makefile   |    8 +
>>>   drivers/staging/media/tegra/TODO       |   10 +
>>>   drivers/staging/media/tegra/common.h   |  262 ++++++++
>>>   drivers/staging/media/tegra/csi.c      |  606 +++++++++++++++++
>>>   drivers/staging/media/tegra/csi.h      |  149 +++++
>>>   drivers/staging/media/tegra/tegra210.c |  709 ++++++++++++++++++++
>>>   drivers/staging/media/tegra/tegra210.h |  190 ++++++
>>>   drivers/staging/media/tegra/vi.c       | 1132
>>> ++++++++++++++++++++++++++++++++
>>>   drivers/staging/media/tegra/vi.h       |   83 +++
>>>   drivers/staging/media/tegra/video.c    |  153 +++++
>>>   drivers/staging/media/tegra/video.h    |   34 +
>>>   14 files changed, 3352 insertions(+)
>>>   create mode 100644 drivers/staging/media/tegra/Kconfig
>>>   create mode 100644 drivers/staging/media/tegra/Makefile
>>>   create mode 100644 drivers/staging/media/tegra/TODO
>>>   create mode 100644 drivers/staging/media/tegra/common.h
>>>   create mode 100644 drivers/staging/media/tegra/csi.c
>>>   create mode 100644 drivers/staging/media/tegra/csi.h
>>>   create mode 100644 drivers/staging/media/tegra/tegra210.c
>>>   create mode 100644 drivers/staging/media/tegra/tegra210.h
>>>   create mode 100644 drivers/staging/media/tegra/vi.c
>>>   create mode 100644 drivers/staging/media/tegra/vi.h
>>>   create mode 100644 drivers/staging/media/tegra/video.c
>>>   create mode 100644 drivers/staging/media/tegra/video.h
>> With 'make menuconfig' I get this:
>>
>> scripts/kconfig/mconf  Kconfig
>>
>> WARNING: unmet direct dependencies detected for TEGRA_HOST1X
>>    Depends on [n]: HAS_IOMEM [=y] && (ARCH_TEGRA || ARM &&
>> COMPILE_TEST [=y])
>>    Selected by [y]:
>>    - VIDEO_TEGRA [=y] && STAGING [=y] && STAGING_MEDIA [=y] &&
>> MEDIA_SUPPORT [=y] && (ARCH_TEGRA || COMPILE_TEST [=y])
>>
>> This is an x86_64 build with COMPILE_TEST set. I can provide my full
>> .config if you need it.
>>
>> CONFIG_TEGRA_HOST1X=y
>> CONFIG_VIDEO_TEGRA=y
>>
>> Regards,
>>
>>          Hans
> 
> Hi Hans,
> 
> In v7, changed Kconfig to remove ARM. But looks like we should limit
> 
> TEGRA_HOST1X also limits compile to ARM only so running VIDEO_TEGRA on
> x86_64 shows above warning.
> 
> We should limit compile to ARM for CONFIG_VIDEO_TEGRA.
> 
> Will update CONFIG_VIDEO_TEGRA dependency to use ARM && COMPILE_TEST
> like I had in previous version. Sorry about this.
> 
> 
> Also, I see some changes went into latest linux-next staging media
> Kconfig, So, will have my patches on top of today's linux-next.

VIDEO_TEGRA should depend on TEGRA_HOST1X and not select it.

depends on (ARCH_TEGRA && TEGRA_HOST1X) || COMPILE_TEST

  reply	other threads:[~2020-04-23 22:55 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22  6:18 [RFC PATCH v9 0/9] Add Tegra driver for video capture Sowjanya Komatineni
2020-04-22  6:18 ` [RFC PATCH v9 1/9] arm64: tegra: Fix sor powergate clocks and reset Sowjanya Komatineni
2020-04-22  6:18 ` [RFC PATCH v9 2/9] arm64: tegra: Add reset-cells to mc Sowjanya Komatineni
2020-04-22  6:18 ` [RFC PATCH v9 3/9] dt-bindings: clock: tegra: Add clk id for CSI TPG clock Sowjanya Komatineni
2020-04-22  6:18 ` [RFC PATCH v9 4/9] clk: tegra: Add Tegra210 CSI TPG clock gate Sowjanya Komatineni
2020-04-22  6:18 ` [RFC PATCH v9 5/9] dt-binding: tegra: Add VI and CSI bindings Sowjanya Komatineni
2020-04-22 17:20   ` Laurent Pinchart
2020-04-22 17:26     ` Sowjanya Komatineni
2020-04-22 17:47       ` Laurent Pinchart
2020-04-22 17:57         ` Sowjanya Komatineni
2020-04-22  6:18 ` [RFC PATCH v9 6/9] media: tegra: Add Tegra210 Video input driver Sowjanya Komatineni
2020-04-23  7:48   ` Hans Verkuil
2020-04-23 16:50     ` Sowjanya Komatineni
2020-04-23 22:55       ` Dmitry Osipenko [this message]
2020-04-23 22:59         ` Sowjanya Komatineni
2020-04-23 23:03           ` Dmitry Osipenko
2020-04-23 23:14             ` Dmitry Osipenko
2020-04-23 23:16   ` Dmitry Osipenko
2020-04-23 23:19     ` Sowjanya Komatineni
2020-04-23 23:20       ` Sowjanya Komatineni
2020-04-23 23:25         ` Dmitry Osipenko
2020-04-23 23:50           ` Sowjanya Komatineni
2020-04-24  0:42             ` Dmitry Osipenko
2020-04-24  0:51               ` Sowjanya Komatineni
2020-04-24  1:08                 ` Sowjanya Komatineni
2020-04-24  2:09                   ` Dmitry Osipenko
2020-04-24  2:12                     ` Sowjanya Komatineni
2020-04-22  6:18 ` [RFC PATCH v9 7/9] MAINTAINERS: Add Tegra Video driver section Sowjanya Komatineni
2020-04-22  6:18 ` [RFC PATCH v9 8/9] dt-bindings: reset: Add ID for Tegra210 VI reset Sowjanya Komatineni
2020-04-22  6:18 ` [RFC PATCH v9 9/9] arm64: tegra: Add Tegra VI CSI support in device tree Sowjanya Komatineni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db413479-1557-3c40-ecb2-5a0c657065b6@gmail.com \
    --to=digetx@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frankc@nvidia.com \
    --cc=helen.koike@collabora.com \
    --cc=hverkuil@xs4all.nl \
    --cc=jonathanh@nvidia.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=sakari.ailus@iki.fi \
    --cc=sboyd@kernel.org \
    --cc=skomatineni@nvidia.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).