From: Tom Rix <trix@redhat.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Nathan Chancellor <natechancellor@gmail.com>,
linux-media@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Huckleberry <nhuck15@gmail.com>
Subject: Re: [PATCH] media: ov7670: check status of ov7670_read
Date: Fri, 28 Aug 2020 08:36:43 -0700 [thread overview]
Message-ID: <db41a471-b5cd-6ffe-c24f-ba14d9125920@redhat.com> (raw)
In-Reply-To: <CAKwvOd=S=aw6KoRvzhUMi4fR799kaPwAKoigjuR9fS-JSYSGPA@mail.gmail.com>
On 8/28/20 8:13 AM, Nick Desaulniers wrote:
> On Fri, Aug 28, 2020 at 7:55 AM <trix@redhat.com> wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> clang static analysis flags this representative problem
>>
>> drivers/media/i2c/ov7670.c:1463:9: warning: Assigned
>> value is garbage or undefined
>> *value = gain;
>> ^ ~~~~
>>
>> gain is set by a successful call to ov7670_read()
> Indeed, it looks like gain is only valid if the return value from
> ov7670_read() is >= 0. Would it be simpler to just initialize gain to
> 0 in ov7670_g_gain?
It looks like ov7670_read() subroutines both convert > 0 returns to 0.
Setting gain, and similar cases, to 0 means it is ok the setting side effect. maybe it would be ok if this was a void return or there was some known poison value. I did not look into that. There are other routines that are more than a simple get() and i wanted to use the same fix for all of them.
yeah on clang static analysis making it into kbuild! I have been doing these fixes for a couple of months. with a just-built clang, i run 'scan-build make randomconfig', 'scan-build make', then run scan-view on the html. the randomconfig accounts for the very scattered fixes i have posted. generally i would say kernel is doing pretty well, maybe 20 to 1 false to real problems.
Tom
>
> Side question; I'm super happy to see someone sending patches for
> things identified by clang's static analyzer. I'm curious, Tom, how
> did you run it? Did you use the recently landed in kbuild-next
> support for the make target `make clang-analyzer`?
>
>> So check that ov7670_read() is successful.
>>
>> The remaining static analysis problems are false positives.
>> There appears to be a limitation with checking the
>> aggregated returns.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>> drivers/media/i2c/ov7670.c | 17 +++++++++++++----
>> 1 file changed, 13 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c
>> index b42b289faaef..001d4b09db72 100644
>> --- a/drivers/media/i2c/ov7670.c
>> +++ b/drivers/media/i2c/ov7670.c
>> @@ -929,6 +929,8 @@ static int ov7670_set_hw(struct v4l2_subdev *sd, int hstart, int hstop,
>> ret = ov7670_write(sd, REG_HSTART, (hstart >> 3) & 0xff);
>> ret += ov7670_write(sd, REG_HSTOP, (hstop >> 3) & 0xff);
>> ret += ov7670_read(sd, REG_HREF, &v);
>> + if (ret)
>> + return ret;
>> v = (v & 0xc0) | ((hstop & 0x7) << 3) | (hstart & 0x7);
>> msleep(10);
>> ret += ov7670_write(sd, REG_HREF, v);
>> @@ -938,6 +940,8 @@ static int ov7670_set_hw(struct v4l2_subdev *sd, int hstart, int hstop,
>> ret += ov7670_write(sd, REG_VSTART, (vstart >> 2) & 0xff);
>> ret += ov7670_write(sd, REG_VSTOP, (vstop >> 2) & 0xff);
>> ret += ov7670_read(sd, REG_VREF, &v);
>> + if (ret)
>> + return ret;
>> v = (v & 0xf0) | ((vstop & 0x3) << 2) | (vstart & 0x3);
>> msleep(10);
>> ret += ov7670_write(sd, REG_VREF, v);
>> @@ -1460,6 +1464,8 @@ static int ov7670_g_gain(struct v4l2_subdev *sd, __s32 *value)
>> unsigned char gain;
>>
>> ret = ov7670_read(sd, REG_GAIN, &gain);
>> + if (ret)
>> + return ret;
>> *value = gain;
>> return ret;
>> }
>> @@ -1470,11 +1476,14 @@ static int ov7670_s_gain(struct v4l2_subdev *sd, int value)
>> unsigned char com8;
>>
>> ret = ov7670_write(sd, REG_GAIN, value & 0xff);
>> + if (ret)
>> + return ret;
>> /* Have to turn off AGC as well */
>> - if (ret == 0) {
>> - ret = ov7670_read(sd, REG_COM8, &com8);
>> - ret = ov7670_write(sd, REG_COM8, com8 & ~COM8_AGC);
>> - }
>> + ret = ov7670_read(sd, REG_COM8, &com8);
>> + if (ret)
>> + return ret;
>> + ret = ov7670_write(sd, REG_COM8, com8 & ~COM8_AGC);
>> +
>> return ret;
>> }
>>
>> --
>> 2.18.1
>>
>
next prev parent reply other threads:[~2020-08-28 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 14:55 [PATCH] media: ov7670: check status of ov7670_read trix
2020-08-28 15:13 ` Nick Desaulniers
2020-08-28 15:36 ` Tom Rix [this message]
2020-10-06 12:41 ` Sakari Ailus
2020-10-06 14:17 ` Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db41a471-b5cd-6ffe-c24f-ba14d9125920@redhat.com \
--to=trix@redhat.com \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mchehab@kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=nhuck15@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).