From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEBEEC433EF for ; Mon, 11 Oct 2021 10:19:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C44C460F22 for ; Mon, 11 Oct 2021 10:19:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235572AbhJKKVY (ORCPT ); Mon, 11 Oct 2021 06:21:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235826AbhJKKVW (ORCPT ); Mon, 11 Oct 2021 06:21:22 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BCACC061570 for ; Mon, 11 Oct 2021 03:19:23 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mZsOv-0000l7-F2; Mon, 11 Oct 2021 12:19:21 +0200 Subject: Re: [PATCH v3] KEYS: trusted: Fix trusted key backends when building as module To: Andreas Rammhold , Mimi Zohar , David Howells , Jarkko Sakkinen , James Bottomley Cc: James Morris , "Serge E. Hallyn" , Sumit Garg , linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210730012822.3460913-1-andreas@rammhold.de> <0d42a11a-0117-49a9-d2c9-bc6cc405235d@pengutronix.de> <20210927085104.vq42feghtaqiv6ni@wrt> <856359f263575f01d0ce2fcf8f042321f750b38c.camel@linux.ibm.com> <20210927200835.wvazk73cek3t5tkf@wrt> <2ad2c536367028ef6d9300745586a123cb13d9f1.camel@linux.ibm.com> <20210927205521.7c4psu4vz5eoyfnf@wrt> <81602197662f3e6d032103bd1ac3690342544b7e.camel@linux.ibm.com> <20211002214725.fqmtbfjwtlom745c@wrt> From: Ahmad Fatoum Message-ID: Date: Mon, 11 Oct 2021 12:19:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211002214725.fqmtbfjwtlom745c@wrt> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Mimi, David, Jarkko and James, On 02.10.21 23:47, Andreas Rammhold wrote: >> My mistake. Trusted and encrypted key types have always been defined >> as tristate. Only when EVM selects encrypted keys, and by extension >> trusted keys, are they builtin. > > So how do we go about this patch? Building the TPM support as module has > broken actually using the trusted backend. This patch fixes that while > still allowing it to be a builtin. If there is some configuration there > a module isn't acceptable I am sure that is handled within Kconfig? Can anyone of you four pick this up? Andreas' regression fix has had Jarkko's Reviewed-by for close to two months and a half now. Thanks, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |