From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1163047AbcG1Fx7 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Jul 2016 01:53:59 -0400
Received: from mout.web.de ([212.227.17.11]:52905 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1162300AbcG1Fxt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Jul 2016 01:53:49 -0400
Subject: Re: staging: lustre: One function call less in class_register_type()
 after error detection
To: Oleg Drokin <oleg.drokin@intel.com>
References: <566ABCD9.1060404@users.sourceforge.net>
 <566D7733.1030102@users.sourceforge.net>
 <56784D83.7080108@users.sourceforge.net>
 <56784F0C.6040007@users.sourceforge.net> <20151221234857.GA27079@kroah.com>
 <59d94e70-7476-728e-5f63-013557ec2db9@users.sourceforge.net>
 <a92aee0c-7a2c-a509-c19e-44cc9d8335a1@users.sourceforge.net>
 <AD87A1DA-2C87-4A36-AA19-45961B51FBE7@intel.com>
 <0f9ecc7c-f98a-0296-563b-6fcfab459c31@users.sourceforge.net>
 <2BFF8460-ECEA-470D-ACD6-A9D7E540FE33@intel.com>
Cc: devel@driverdev.osuosl.org, lustre-devel@lists.lustre.org,
        Andreas Dilger <andreas.dilger@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>,
        Bhumika Goyal <bhumirks@gmail.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <db6cbbce-d3ff-2b92-199b-a8e5fd99dd40@users.sourceforge.net>
Date: Thu, 28 Jul 2016 07:53:18 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2
MIME-Version: 1.0
In-Reply-To: <2BFF8460-ECEA-470D-ACD6-A9D7E540FE33@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:fjBadn9gvXhMjW2kHACM6Se2jaP/Matk4sTCmizzHmH3PyhQ05Q
 /iQqQYHwN266yCUlg3vsswJ12l5U/cJ37ORmnf0p2wEiJsmak/ApmMgWHqBgh63WNtHl+7k
 8WoAMYVPvLmo8Nku7kzhbfdd9o+JxHVhpBQ6sEuaEYNX8U2w5CiSCoM58HHx4mo2n7U1yGX
 LEsfrmEO9ClCUdJWoaWTw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:Mad8NleS6/U=:aLjTF7UVq+4rujFFgNOaej
 88Mdk+AbtU6SHDrCAqNks3apeW96CDdPllleDCfyBDO1Kavr9GUhQztDK32MDckabWy58bVgo
 oPIQQzPnforlPumhhs//Jm+hSkov8eHYY/pOSLrtlKV8hnTId6qwPzzhMXSQfYFmRNb5NeSdn
 9d+8HXBgcq1pqTpKbU9rXnhjYxggdFysH3y5kjyo/0aulxR7fEPx9NoknnteWR9Kjutrt97mz
 f9zFochcTl6VexJy9nZXCTetErtnMPDt6aCxk1XSgsiE7ZzYI+AXxaxTxY/zSRS2N0A+plr30
 mG3OODbLy3GFO86spcfUrCeDcpjrAZIL61VurXilwyGJBRYbeu63Dzng3yShCfTrhrKNYhC1F
 Q1pIN31K7UhCYN9Pogy1rCSs3khMHr3jKP/DkveUtBMbfDEGZsXIYw152Y5wQ2Rn7Hw+t5V/N
 YAWjtnBGkQG0PNiynXt2wP2nmJ/NbR6rKYF7og1Ph97Y8F3IoZ5xID1rpouyYIS0NSs1xLsTA
 Jv4s0tGF+5FvfV74eNs0mCwuq6Z+3yVoC5HlleZK7Sw42T2bVSvOUyx5C8ChLMj68Msq0+f1W
 SR2TgTXPoCRC/egMN+cRqIIY1S15KGZSRZdXaCXyWJap396WGN8YD7ZD8LchBAd+fwSZU1IhZ
 wO0hnAB/G9KkXp/QDlpPhE5hHjWSpN+VrUseUBm3pMMccCQbyn23DiiyIpGL8l24vw2Iva6qB
 QbsRlz+z+2+LRls4l7dhAcnEy2nugOYeiKvairbza4DVNK2rxvJyL7mlHK/Pdzq7azvCnOT3n
 I/pJ3VB
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> This function is called several times during lustre module insert.
> Namely it's called 5 times for 5 types:
> osc, mdc, lov, lmv, mgc.

Will any extra memory accesses matter for the successful execution
in this use case?


> It's not called any more than that, so it's not exactly a super hot-path function
> to overoptimize it, and the failure is presumed to never happen too
> (or the module would be non-functional).

Did the assignment for the local variable "rc" with a well-known error code
influence the run-time characteristics in unwanted ways?
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/staging/lustre/lustre/obdclass/genops.c?id=6a5b99a46bedc2cfbba96dec6d255c4b90af9ff8#n140

Regards,
Markus