linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: jiaxun.yang@flygoat.com, Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Huacai Chen <chenhc@lemote.com>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH v2 2/2] MIPS: Fix build errors under CONFIG_HAVE_STD_PC_SERIAL_PORT
Date: Fri, 15 May 2020 16:54:09 +0800	[thread overview]
Message-ID: <db6fda56-27da-3705-1270-805e61defe4b@loongson.cn> (raw)
In-Reply-To: <5AA0EB3A-DF33-4BE7-804C-45F6B51A0CF7@flygoat.com>

On 05/15/2020 04:19 PM, Jiaxun Yang wrote:
>
> 于 2020年5月15日 GMT+08:00 下午3:54:46, Tiezhu Yang <yangtiezhu@loongson.cn> 写到:
>> On 05/15/2020 03:39 PM, Thomas Bogendoerfer wrote:
>>> On Fri, May 15, 2020 at 11:23:05AM +0800, Tiezhu Yang wrote:
>>>> When CONFIG_HAVE_STD_PC_SERIAL_PORT is set, include linux/module.h to fix
>>>> the following build errors:
>>> how are you doing this ? To me it looks like this CONFIG option isn't
>>> used anymore.
>> Because I will use arch/mips/kernel/8250-platform.c in the near future,
>> so make MACH_LOONGSON64 selects HAVE_STD_PC_SERIAL_PORT, then
>> I find the build errors.
> Please never use it.
> If you are willing to add serial port then please do it
> in devicetree.
> Platform devices in wild is dangerous and it will break everything.

Hi Jiaxun,

OK, Thanks for your suggestion. I will rethink my plan.

Hi Thomas,

Because CONFIG_HAVE_STD_PC_SERIAL_PORT is not used anymore,
(1) Is it necessary to fix this possible build error?
or
(2) Should we remove this arch/mips/kernel/8250-platform.c?

Thanks,
Tiezhu Yang

>
>> Thanks,
>> Tiezhu Yang
>>
>>> Thomas.
>>>


  reply	other threads:[~2020-05-15  8:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15  3:23 [PATCH v2 1/2] MIPS: Loongson: Build ATI Radeon GPU driver as module Tiezhu Yang
2020-05-15  3:23 ` [PATCH v2 2/2] MIPS: Fix build errors under CONFIG_HAVE_STD_PC_SERIAL_PORT Tiezhu Yang
2020-05-15  7:39   ` Thomas Bogendoerfer
2020-05-15  7:54     ` Tiezhu Yang
2020-05-15  8:19       ` Jiaxun Yang
2020-05-15  8:54         ` Tiezhu Yang [this message]
2020-05-15 16:55           ` Thomas Bogendoerfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db6fda56-27da-3705-1270-805e61defe4b@loongson.cn \
    --to=yangtiezhu@loongson.cn \
    --cc=chenhc@lemote.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=lixuefeng@loongson.cn \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).